Stop using docker.io/bitnami images and possibly bitnami charts

[reggie-k]

Describe the bug

Bitnami is changing their public catalog policy:
bitnami/charts#35164
We are no longer using Bitnami images for the Argo CD image, but using Bitnami images and charts in our CI. If we don't make a change till Aug 28, builds will start to fail.

We can temporarily replace docker.io/bitnami images with docker.io/bitnamilegacy images and figure out a long-term solution later. It seems that only tagged images must be replaced, as the latest images, as per Bitnami statement, will still be available.

We also use Bitnamii charts, and while those are not directly impacted, if they use tagged images pointing to docker.io/bitnami, we should be using other charts.

Related helm chart

argo-cd

Helm chart version

8.2.7

To Reproduce

Search for bitnami in the codebase and handle according to the description.

Expected behavior

Switching to bitnamilegacy where applicable for docker images and for bitnami charts - if we use them, and they don't use bitnamilegacy, replace them with other charts.

Screenshots

No response

Additional context

No response

[mkilchhofer]

We only use it to test the external redis feature during CI:
https://github.com/search?q=repo%3Aargoproj%2Fargo-helm%20bitnami&type=code

Do we want to replace it with Valkey, @mbevc1 , @tico24 , @yu-croco , @jmeridth ?

[mbevc1]

Yeah, I'd vote us to move away from Bitnami

[yu-croco]

I agree with Valkey🥳

[tico24]

I generally agree, but only for CI things.
For now, we have to keep supporting actual redis within the chart itself because that's what upstream Argo CD requires :( - I am aware that there are discussions upstream to replace redis.

Another counterpoint is that we would then be testing external redis with Not Redis. I think the risk is fine, but we should probably document that or something?

[tico24]

Just to point out the obvious, the dandydeveloper chart that we ship with our actual argo cd helm chart does not use bitnami. So we could just use that internally, which is probably better testing?

https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/Chart.yaml#L22

[tico24]

Finally, just in case you weren't aware, bitnami moved the deadline back a month: bitnami/containers#83267

[mkilchhofer]

It seems like the "best" chart for Valkey was also from Bitnami... darn😬