feat(argo-cd): Add Gateway API support #2689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdrastil
force-pushed
the
feature/gateway-api
branch
from
be5fb00 to
e86810b
Compare
pdrastil
force-pushed
the
feature/gateway-api
branch
from
e86810b to
f8698ad
Compare
gazal-k
reviewed
Jun 14, 2024
| - group: gateway.networking.k8s.io | ||
| kind: Gateway | ||
| name: {{ .Values.server.gatewayAPI.gateway }} | ||
| {{- with .Values.server.gatewayAPI.gatewaySection }} |
Contributor
There was a problem hiding this comment.
Could you please add support for referencing Gateways in other namespaces
Suggested change
| {{- with .Values.server.gatewayAPI.gatewaySection }} | |
| {{- with .Values.server.gatewayAPI.gatewayNamespace }} | |
| namespace: {{ . }} | |
| {{- end }} | |
| {{- with .Values.server.gatewayAPI.gatewaySection }} |
Signed-off-by: Petr Drastil <[email protected]>
pdrastil
force-pushed
the
feature/gateway-api
branch
from
f8698ad to
0117c1c
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
6 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2634
Draft to get initial feedback from community
Checklist: