Skip to content

feat(argo-cd): gateway support #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tduverge wants to merge 16 commits into from
Closed

feat(argo-cd): gateway support #2965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0117c1c
feat(argo-cd): Add Gateway API support
pdrastil May 12, 2024
b5b6099
Merge branch 'main' into feature/gateway-api
pdrastil Sep 8, 2024
650c4e0
feat(argo-cd): update Chart.yaml version to 7.7.0
tduverge Oct 2, 2024
5d0a8a2
feat(argo-cd): disable gatewayAPI route by default
tduverge Oct 4, 2024
59c226c
feat(argo-cd): add gateway creation and gke objects
tduverge Oct 4, 2024
a8d4216
feat(argo-cd): support references in spec
tduverge Oct 4, 2024
44377b3
ref(argo-cd): using default value for gateway name
tduverge Oct 4, 2024
6e88266
doc(argo-cd): generate documentation
tduverge Oct 4, 2024
0b5b4d8
doc(argo-cd): add changelogs
tduverge Oct 4, 2024
7429937
feat(argo-cd): add gateway namespace configuration
tduverge Oct 4, 2024
4ec0b60
feat(argo-cd): setting gateway resources namespace from tpl "argo-cd.…
tduverge Oct 4, 2024
cd7f480
Merge remote-tracking branch 'origin/main' into feature/gateway-api
Oct 4, 2024
68abeeb
feat(argo-cd): remove trailing spaces to pass script lint
tduverge Oct 4, 2024
281e031
fix(argo-cd): wrong port or health check on argo server
tduverge Oct 4, 2024
4d06899
fix(argo-cd): invalid reference to ingress in gateway route
tduverge Oct 4, 2024
b51c851
fix(argo-cd): remove useless key in ingress
tduverge Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc(argo-cd): generate documentation 
Signed-off-by: Tristan Duverger <tristan.duverger@gmail.com>
  • Loading branch information
@tduverge
tduverge authored and Tristan Duverger committed Oct 4, 2024
commit 6e8826641443322def667f498c162a1ae4fb0d19
27 changes: 27 additions & 0 deletions charts/argo-cd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,33 @@ NAME: my-release
| server.extensions.resources | object | `{}` | Resource limits and requests for the argocd-extensions container |
| server.extraArgs | list | `[]` | Additional command line arguments to pass to Argo CD server |
| server.extraContainers | list | `[]` | Additional containers to be added to the server pod |
| server.gateway.annotations | object | `{}` | Additional gateway annotations |
| server.gateway.controller | string | `"None"` | Specific implementation for gateway controller. Only `None` and `gke` are supported. |
| server.gateway.enabled | bool | `false` | enable a gateway resource for ArgoCD |
| server.gateway.gatewayClassName | string | `""` (See [values.yaml]) | Getaway class name |
| server.gateway.gke.GCPBackendPolicy.annotations | object | `{}` (See [values.yaml]) | Additional backend policy annotations |
| server.gateway.gke.GCPBackendPolicy.labels | object | `{}` (See [values.yaml]) | Additional backend policy labels |
| server.gateway.gke.GCPBackendPolicy.spec.default | object | `{}` (See [values.yaml]) | Default spec for GCPBackendPolicy |
| server.gateway.gke.GCPGatewayPolicy.annotations | object | `{}` (See [values.yaml]) | Additional gateway policy annotations |
| server.gateway.gke.GCPGatewayPolicy.labels | object | `{}` (See [values.yaml]) | Additional gateway policy labels |
| server.gateway.gke.GCPGatewayPolicy.spec.default | object | `{}` (See [values.yaml]) | Default spec for GCPGatewayPolicy |
| server.gateway.gke.HealthCheckPolicy.annotations | object | `{}` (See [values.yaml]) | Additional heath check policy annotations |
| server.gateway.gke.HealthCheckPolicy.labels | object | `{}` (See [values.yaml]) | Additional heath check policy labels |
| server.gateway.gke.HealthCheckPolicy.spec.default | object | Logs enabled and Heath check on argo server service (See [values.yaml]) | Default spec for GCP HealthCheckPolicy |
| server.gateway.httpRoute.annotations | object | `{}` (See [values.yaml]) | Additional route annotations |
| server.gateway.httpRoute.enabled | string | Same value than server.gateway.enabled (See [values.yaml]) | Enable a Gateway HTTP route resources for the Argo CD server |
| server.gateway.httpRoute.extraHosts | list | `[]` (See [values.yaml]) | The list of additional hostnames to be covered by API Gateway record |
| server.gateway.httpRoute.extraPaths | list | `[]` (See [values.yaml]) | Additional API Gateway paths |
| server.gateway.httpRoute.extraRules | list | `[]` (See [values.yaml]) | Additional routing rules |
| server.gateway.httpRoute.gateway | string | `""` (See [values.yaml]) | Defines which Gateway will implement the resource |
| server.gateway.httpRoute.gatewaySection | string | `""` (See [values.yaml]) | Defines which Gateway section will implement the resource |
| server.gateway.httpRoute.hostname | string | `""` (defaults to global.domain) | Argo CD server hostname |
| server.gateway.httpRoute.labels | object | `{}` (See [values.yaml]) | Additional route labels |
| server.gateway.httpRoute.path | string | `/` (See [values.yaml]) | The path to Argo CD server |
| server.gateway.httpRoute.pathType | string | `PathPrefix` (See [values.yaml]) | HTTP reoute path type. Either 'Exact' or `PathPrefix` |
| server.gateway.labels | object | `{}` | Additional gateway labels |
| server.gateway.listeners | list | Listen on http. | Gateway listeners |
| server.gateway.name | string | `""` (calculated with template "argo-cd.server.fullname") (See [values.yaml]) | Name of the new gateway |
| server.hostNetwork | bool | `false` | Host Network for Server pods |
| server.image.imagePullPolicy | string | `""` (defaults to global.image.imagePullPolicy) | Image pull policy for the Argo CD server |
| server.image.repository | string | `""` (defaults to global.image.repository) | Repository to use for the Argo CD server |
Expand Down
35 changes: 27 additions & 8 deletions charts/argo-cd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2168,10 +2168,15 @@ server:
labels: {}
# -- Additional gateway annotations
annotations: {}
# networking.gke.io/certmap: "CERTIFICATE_MAP"
gatewayClassName: ""
#networking.gke.io/certmap: "CERTIFICATE_MAP_NAME"

# -- Getaway class name
# @default -- `""` (See [values.yaml])
## Example: gatewayClassName: gke-l7-global-external-managed
gatewayClassName: ""
# -- Gateway listeners
# @default -- Listen on http.
## Notes: Enabled https required ssl configuration depending on your k8s environment
listeners:
- name: http
protocol: HTTP
Expand All @@ -2188,30 +2193,36 @@ server:
gke:
GCPGatewayPolicy:
# -- Additional gateway policy labels
# @default -- `{}` (See [values.yaml])
labels: {}
# -- Additional gateway policy annotations
# @default -- `{}` (See [values.yaml])
annotations: {}
spec:
# @default -- `{}`
## Note: default spec for GCPGatewayPolicy
# -- Default spec for GCPGatewayPolicy
# @default -- `{}` (See [values.yaml])
default: {}
GCPBackendPolicy:
# -- Additional backend policy labels
# @default -- `{}` (See [values.yaml])
labels: {}
# -- Additional backend policy annotations
# @default -- `{}` (See [values.yaml])
annotations: {}
spec:
# -- Default spec for GCPBackendPolicy
# @default -- `{}` (See [values.yaml])
## Note: default spec for GCPBackendPolicy
default: {}
HealthCheckPolicy:
# -- Additional heath check policy labels
# @default -- `{}` (See [values.yaml])
labels: {}
# -- Additional heath check policy annotations
# @default -- `{}` (See [values.yaml])
annotations: {}
spec:
# @default -- `` (See [values.yaml])
## Note: default spec for HealthCheckPolicy. Logs enabled and Heath check on argo server service
# -- Default spec for GCP HealthCheckPolicy
# @default -- Logs enabled and Heath check on argo server service (See [values.yaml])
default:
logConfig:
enabled: true
Expand All @@ -2224,29 +2235,37 @@ server:
# NOTE: Alpha feature, gRPC & TLS pass-through will not work
httpRoute:
# -- Enable a Gateway HTTP route resources for the Argo CD server
enabled: "{{ .Values.server.gateway.enabled | default false }}"
# @default -- Same value than server.gateway.enabled (See [values.yaml])
enabled: "{{ .Values.server.gateway.enabled }}"
# -- Additional route labels
# @default -- `{}` (See [values.yaml])
labels: {}
# -- Additional route annotations
# @default -- `{}` (See [values.yaml])
annotations: {}

# -- Defines which Gateway will implement the resource
# @default -- `""` (See [values.yaml])
gateway: ""

# -- Defines which Gateway section will implement the resource
# @default -- `""` (See [values.yaml])
gatewaySection: ""

# -- Argo CD server hostname
# @default -- `""` (defaults to global.domain)
hostname: ""

# -- The path to Argo CD server
# @default -- `/` (See [values.yaml])
path: /

# -- HTTP reoute path type. Either 'Exact' or `PathPrefix`
# @default -- `PathPrefix` (See [values.yaml])
pathType: PathPrefix

# -- The list of additional hostnames to be covered by API Gateway record
# @default -- `[]` (See [values.yaml])
extraHosts: []

# -- Additional API Gateway paths
Expand Down