feat(argo-rollouts): Support ability to set .Values.namespaceOverride #3375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tcaenen <[email protected]>
yu-croco
reviewed
Jul 2, 2025
Co-authored-by: Aikawa <[email protected]> Signed-off-by: tcaenen <[email protected]>
yu-croco
reviewed
Jul 3, 2025
yu-croco
previously approved these changes
Jul 5, 2025
Collaborator
yu-croco
left a comment
yu-croco
left a comment
There was a problem hiding this comment.
Thank you for your contribution. LGTM.
mkilchhofer
requested changes
Jul 8, 2025
Member
mkilchhofer
left a comment
mkilchhofer
left a comment
There was a problem hiding this comment.
Almost LGTM. Found 2 search/replace issues
Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>
mkilchhofer
reviewed
Jul 8, 2025
Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>
mkilchhofer
approved these changes
Jul 8, 2025
Member
mkilchhofer
left a comment
mkilchhofer
left a comment
There was a problem hiding this comment.
Thanks for your contribution @tcaenen
yu-croco
approved these changes
Jul 9, 2025
yaringol
pushed a commit
to yaringol/argo-helm
that referenced
this pull request
Jul 12, 2025
…argoproj#3375) Signed-off-by: Yarin Golzar <[email protected]>
mkilchhofer
added a commit
that referenced
this pull request
Sep 16, 2025
…er (#3365) * chore(deps): update renovatebot/github-action action to v43 (#3363) Signed-off-by: Yarin Golzar <[email protected]> * added VerticalPodAutoscaler support for application controller #3232 Signed-off-by: Yarin Golzar <[email protected]> * removed trailing spaces Signed-off-by: Yarin Golzar <[email protected]> * chore(deps): update renovatebot/github-action action to v43.0.1 (#3366) Signed-off-by: Yarin Golzar <[email protected]> * fix(argo-cd): do not use hardcoded commit server URL (#3367) * fix(argo-cd): do not use hardcoded commit server URL This commit adds the required template logic to the Argo CD Helm chart to use the proper, release name dependent URL for the commit server. The current implementation uses the default hardcoded URL `argocd-commit-server:8086` from <https://github.com/argoproj/argo-cd/blob/v3.0.9/common/common.go#L31>. Signed-off-by: Alexej Disterhoft <[email protected]> * chore(argo-cd): update version to 8.1.2 Signed-off-by: Alexej Disterhoft <[email protected]> * docs(argo-cd): add commit server service port and port name to README Signed-off-by: Alexej Disterhoft <[email protected]> --------- Signed-off-by: Alexej Disterhoft <[email protected]> * chore(deps): bump github/codeql-action from 3.29.0 to 3.29.1 in the dependencies group (#3370) chore(deps): bump github/codeql-action in the dependencies group Bumps the dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 3.29.0 to 3.29.1 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@ce28f5b...39edc49) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.29.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Yarin Golzar <[email protected]> * chore(deps): update renovatebot/github-action action to v43.0.2 (#3371) Signed-off-by: Yarin Golzar <[email protected]> * chore(deps): update ghcr.io/renovatebot/renovate docker tag to v41 (#3373) Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Yarin Golzar <[email protected]> * chore(deps): bump github/codeql-action from 3.29.1 to 3.29.2 in the dependencies group (#3378) chore(deps): bump github/codeql-action in the dependencies group Bumps the dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 3.29.1 to 3.29.2 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@39edc49...181d5ee) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.29.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Yarin Golzar <[email protected]> * feat(argo-rollouts): Support ability to set .Values.namespaceOverride (#3375) Signed-off-by: Yarin Golzar <[email protected]> * updated docs to match vpa default values settings Signed-off-by: Yarin Golzar <[email protected]> * chore(argo-cd): Update dependency argoproj/argo-cd to v3.0.11 (#3380) --------- Signed-off-by: Yarin Golzar <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Yarin Golzar <[email protected]> Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Co-authored-by: Yarin Golzar <[email protected]> Co-authored-by: Alexej Disterhoft <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tcaenen <[email protected]> Co-authored-by: Marco Maurer (-Kilchhofer) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for overriding the namespace used in the Argo Rollouts Helm chart via a new value:
namespaceOverride.Checklist: