Skip to content

chore(argo-cd): replace bitnami redis image with bitnamilegacy redis image #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reggie-k wants to merge 2 commits into from
Closed

chore(argo-cd): replace bitnami redis image with bitnamilegacy redis image #3452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbc52f0
replace bitnami redis image with bitnamilegacy redis image
reggie-k Aug 27, 2025
384a73d
Merge branch 'main' into patch-1
yu-croco Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
run: |
kubectl create namespace redis
helm repo add bitnami https://charts.bitnami.com/bitnami
helm install redis bitnami/redis --wait --namespace redis --set auth.password=argocd --set architecture=standalone
helm install redis bitnami/redis --wait --namespace redis --set auth.password=argocd --set architecture=standalone --set global.image.repository=bitnamilegacy/redis
Copy link
Member

@nitishfy nitishfy Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this override the existing image here - helm install redis bitnami/redis?

Also, shouldn't we be using official redis image instead as discussed in meeting?

Copy link
Member Author

@reggie-k reggie-k Aug 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the image will be overridden. For now, using the bitnami chart, which will not be impacted at the near future as per their statement, but just with a different image. This is a short term solution.

Copy link
Member

@nitishfy nitishfy Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we simply run helm install redis bitnamilegacy/redis --wait.... than using the set flag?


- name: Run chart-testing (install)
run: ct install --config ./.github/configs/ct-install.yaml
Expand Down