docs(cli): add example field to argo cluster-template create. Fixes #11898#12101
Conversation
…ixes argoproj#11898 Signed-off-by: shubhamch71 <shubhamchau71@gmail.com>
Signed-off-by: shubhamch71 <shubhamchau71@gmail.com>
…goproj#11898 Signed-off-by: shubhamch71 <shubhamchau71@gmail.com>
|
@agilgur5 I ran the command |
|
The diff in CI is showing that the indentation changed from spaces to tabs. Not sure if your editor may have accidentally converted it to spaces? |
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
thanks for writing up some examples. I left some comments in-line.
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Signed-off-by: shubhamch71 <shubhamchau71@gmail.com>
shubhamch71
force-pushed
the
create-template-command-examples--help-output
branch
from
bf53de8 to
a4fdd98
Compare
Signed-off-by: shubhamch71 <shubhamchau71@gmail.com>
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
codegen is still failing due to indentation differences. lint is now also failing due to incorrect indentation.
see in-line comments below:
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
…roj#11898 Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
…create command. Fixes argoproj#11898 Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM, lint and codegen now pass! thanks for working through the CI issues 🙂
@agilgur5 I am grateful for your guidance and support in overcoming these challenges. Having gained a better understanding of this , I am now going to contribute to other commands of issue #11898. It's all thanks to you!!! 🙂 |
3 participants
Fixes #11898
Motivation
Changes to support more detailed information when the user runs the argo cluster-template create command
Modifications
Added examples for some common usages of argo cluster-template create command
Verification
RUN
argo cluster-template create --help