-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: implement Delete func of OSS ArtifactDriver. Fixes #9349 #12907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AlbeeSo <[email protected]> Co-authored-by: shuangkun <[email protected]> Signed-off-by: AlbeeSo <[email protected]>
Member
|
I tested it in my envirment. When workflow completed the on-completion.txt in oss was garbage collected. when workflow deleted the on-deletion.txt in oss was garbage collected. So LGTM. |
shuangkun
approved these changes
Apr 7, 2024
terrytangyuan
approved these changes
Apr 7, 2024
6 tasks
shuangkun
added a commit
to shuangkun/argo-workflows
that referenced
this pull request
Dec 12, 2025
OSS garbage collection was implemented in PR argoproj#12907 by AlbeeSo. This commit updates the documentation to reflect that OSS now supports garbage collection. Co-authored-by: AlbeeSo <[email protected]> Fixes argoproj#9349 Signed-off-by: shuangkun <[email protected]>
shuangkun
added a commit
to shuangkun/argo-workflows
that referenced
this pull request
Dec 12, 2025
OSS garbage collection was implemented in PR argoproj#12907 by AlbeeSo. This commit updates the documentation to reflect that OSS now supports garbage collection. Co-authored-by: AlbeeSo <[email protected]> Fixes argoproj#9349 Signed-off-by: shuangkun <[email protected]>
shuangkun
added a commit
to shuangkun/argo-workflows
that referenced
this pull request
Dec 12, 2025
OSS garbage collection was implemented in PR argoproj#12907 by AlbeeSo. This commit updates the documentation to reflect that OSS now supports garbage collection. Co-authored-by: AlbeeSo <[email protected]> Fixes argoproj#9349 Signed-off-by: shuangkun <[email protected]>
shuangkun
added a commit
to shuangkun/argo-workflows
that referenced
this pull request
Dec 12, 2025
OSS garbage collection was implemented in PR argoproj#12907 by AlbeeSo. This commit updates the documentation to reflect that OSS now supports garbage collection. Co-authored-by: AlbeeSo <[email protected]> Co-authored-by: shuangkun <[email protected]> Signed-off-by: AlbeeSo <[email protected]> Fixes argoproj#9349 Signed-off-by: shuangkun <[email protected]>
shuangkun
added a commit
to shuangkun/argo-workflows
that referenced
this pull request
Dec 12, 2025
OSS garbage collection was implemented in PR argoproj#12907 by AlbeeSo. This commit updates the documentation to reflect that OSS now supports garbage collection. Co-authored-by: AlbeeSo <[email protected]> Co-authored-by: shuangkun <[email protected]> Fixes argoproj#9349 Signed-off-by: shuangkun <[email protected]>
shuangkun
added a commit
to shuangkun/argo-workflows
that referenced
this pull request
Dec 12, 2025
OSS garbage collection was implemented in PR argoproj#12907 by AlbeeSo. This commit updates the documentation to reflect that OSS now supports garbage collection. Co-authored-by: AlbeeSo <[email protected]> Co-authored-by: shuangkun <[email protected]> Signed-off-by: shuangkun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9349
Motivation
argo-workflows/workflow/artifacts/oss/oss.go
Line 226 in 3b4551b
OSS Artifact Driver still NOT support Artifact Garbage Collection as Delete Func has not been implemented.
Modifications
Implemented Delete Func of OSS Artifact Driver .
Verification
Plz check with workflow like