refactor: separate workflow archive queue into own controller#13536
Open
ChenRussell wants to merge 1 commit intoargoproj:mainfrom
Open
refactor: separate workflow archive queue into own controller#13536ChenRussell wants to merge 1 commit intoargoproj:mainfrom
ChenRussell wants to merge 1 commit intoargoproj:mainfrom
Conversation
ChenRussell
force-pushed
the
archive-controller
branch
2 times, most recently
from
367d456 to
f09a151
Compare
Contributor
Author
Joibel
reviewed
Sep 3, 2024
ChenRussell
force-pushed
the
archive-controller
branch
from
f09a151 to
9a3abf3
Compare
Joibel
requested changes
Sep 3, 2024
Signed-off-by: chenrui <chenrui7@kingsoft.com>
ChenRussell
force-pushed
the
archive-controller
branch
from
9a3abf3 to
83cf139
Compare
Member
|
Thank you for doing this. Code inspection looks good but I'd like to find a bit of time for a local test before merging. |
Contributor
Author
|
Thanks, take your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
seperate out workflow archive queue into it's own controller, to make it clear and easy to read
Modifications
build a new controller for workflow archive queue
Verification
run locally and tested