Skip to content

feat(ui): add warning message when deleting CronWorkflow about orphaned Workflows #14727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasonM merged 4 commits into from
Dec 8, 2025
Merged

feat(ui): add warning message when deleting CronWorkflow about orphaned Workflows #14727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d99f4dd
fix(ui): warn CronWorkflow deletion also deletes spawned Workflows. R…
miinsun Jul 28, 2025
a7956ca
Merge branch 'argoproj:main' into f/cronworkflow-keep-orpahs-ui-#14679
miinsun Aug 1, 2025
e45075c
feat(ui): add info message to CronWorkflow delete modal
miinsun Aug 2, 2025
27be625
Merge branch 'main' into f/cronworkflow-keep-orpahs-ui-#14679
miinsun Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .features/pending/14679-cronworkflow-delete-warning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Component: UI
Issues: 14679
Description: Add an informational message to the CronWorkflow delete confirmation modal indicating that Workflows created by the CronSchedule will also be deleted.
Author: [minsun yun](https://github.com/miinsun)

- UI/UX only; **no functional logic** is changed.
- Verified manually by deleting a CronWorkflow in the Workflows UI and confirming the message renders correctly.
2 changes: 1 addition & 1 deletion ui/src/cron-workflows/cron-workflow-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export function CronWorkflowDetails({match, location, history}: RouteComponentPr
iconClassName: 'fa fa-trash',
disabled: edited,
action: () => {
popup.confirm('confirm', 'Are you sure you want to delete this cron workflow?').then(yes => {
popup.confirm('confirm', 'Are you sure you want to delete this cron workflow? (This also deletes all Workflows it spawned)').then(yes => {
if (yes) {
services.cronWorkflows
.delete(name, namespace)
Expand Down
Loading