-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(ui): add label filter sync with URL query params #14816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add label filter sync with URL query params #14816
Conversation
Signed-off-by: puretension <[email protected]>
Signed-off-by: puretension <[email protected]>
eduardodbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally with success
|
Hi @eduardodbr, Thanks for approving! After implementing this fix, Duplicate patterns found:• workflows-list.tsx + workflow-template-list.tsx: Same useState + queryParams + localStorage logic Duplicated code pattern:Proposal:Would you be interested in a follow-up PR after this merges that extracts this • Eliminate code duplication Let me know what you think! |
|
Hey, I would really like to have this feature. Is there any way I can contribute so that it can be released? |
Joibel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking the time to do this.
Signed-off-by: puretension <[email protected]>
Signed-off-by: puretension <[email protected]>
Fixes #14807
Motivation
WorkflowTemplates UI silently ignores label query parameters (e.g.,
?label=key%3Dvalue) unlike Workflows list, breaking URL filtering and preventing custom UI links for filtered template views.Modifications
ref-recorded-video.mov
Verification
?label=key%3Dvaluenow properly filters WorkflowTemplatesDocumentation