Skip to content

feat: allow overriding retry backoff parameters for kubectl commands #15053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GonzaloLuminary wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow overriding retry backoff parameters for kubectl commands #15053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions workflow/executor/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/cli-runtime/pkg/genericclioptions"
"k8s.io/client-go/util/retry"
retryk8s "k8s.io/client-go/util/retry"
"k8s.io/gengo/namer"
gengotypes "k8s.io/gengo/types"
kubectlcmd "k8s.io/kubectl/pkg/cmd"
Expand All @@ -31,6 +31,7 @@ import (
envutil "github.com/argoproj/argo-workflows/v3/util/env"
argoerr "github.com/argoproj/argo-workflows/v3/util/errors"
"github.com/argoproj/argo-workflows/v3/util/logging"
"github.com/argoproj/argo-workflows/v3/util/retry"
)

// ExecResource will run kubectl action against a manifest
Expand All @@ -41,7 +42,7 @@ func (we *WorkflowExecutor) ExecResource(ctx context.Context, action string, man
}

var out []byte
err = retry.OnError(retry.DefaultBackoff, func(err error) bool {
err = retryk8s.OnError(retry.DefaultRetry(ctx), func(err error) bool {
return argoerr.IsTransientErr(ctx, err)
}, func() error {
out, err = runKubectl(ctx, args...)
Expand Down
Loading