fix: rename variables #15061 and add failure error #15067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <[email protected]>
Joibel
added
area/telemetry/metrics
cherry-pick/3.7
eduardodbr
approved these changes
Nov 24, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect variable naming from PR #15061 where GRPC and HTTP exporters were swapped, and adds error handling for unsupported OTLP protocol values.
- Corrected variable names to match their actual exporter types (grpcExporter for GRPC, httpExporter for HTTP)
- Added validation error with fatal logging for invalid OTLP protocol values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MasonM
approved these changes
Nov 26, 2025
|
❌ Cherry-pick failed for 3.7. Please check the workflow logs for details. |
Joibel
added a commit
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Alan Clucas <[email protected]>
guanguxiansheng
pushed a commit
to guanguxiansheng/argo-workflows
that referenced
this pull request
Dec 15, 2025
…15067) Signed-off-by: Alan Clucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixups for #15061 which I probably reviewed too quickly.
Variable names used are the wrong way round.
Added a fatal log if you attempt to use a protocol we don't understand to try to prevent confusion where this doesn't start any exporter.