fix: always convert singular to plural

[Joibel]

In #14996 the singular version of each of semaphore, mutex would not get moved over to the plural in the presence of both fields.

This is not really correct as if you have both sets in 3.7 you will get the behaviour of the appended list+singular. So this PR makes convert append instead of only replace.

For schedule, if present it would mask schedules. I have kept this behaviour.

Added tests for this.

[Copilot]

Pull request overview

This PR fixes the conversion logic for migrating legacy singular fields (semaphore, mutex, schedule) to their plural equivalents (semaphores, mutexes, schedules) in workflow specifications. Previously, the singular fields were only migrated when the plural fields were empty; now they are always appended to ensure both values are preserved when present.

• Changed conversion strategy from conditional replacement to unconditional append
• Updated conversion logic for LegacySynchronization.ToCurrent() to always append singular Semaphore and Mutex to their plural forms
• Updated conversion logic for LegacyCronWorkflowSpec.ToCurrent() to always append singular Schedule to plural Schedules

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.7. Please check the workflow logs for details.