fix: permission error for executor plugin example doc #13015 #15111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Executor Plugin example documentation does not run correctly as it is today with the following error: ``` PermissionError: [Errno 13] Permission denied: '/var/run/argo/token' ``` The user set to run the python plugin is incorrect. It should be `1000` for the particular image we use in the example. Dejan Golja identified and fixed the issue in its own PR, still open today: argoproj#13019 I tried to rebase it on top of main but the page changed a bit and it is hard to merge conflicts today. With this fix the examples works correctly Co-Authored-By: Dejan Golja <[email protected]> Signed-off-by: Gianluca Arbezzano <[email protected]>
Contributor
Author
|
Looking at it a bit deeper I realized that this may not be the right fix. I was inspecting the image used for this plugin This fix works probably because the user is in the group root so it can read the actual file, but this is not what I think we want to advertise for since we want to run rootless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13015
Fixes #13019
Motivation
The current example in the documentation does not run correclty
If fails with the following error:
Modifications
The fix was already discovered and applied by Dejan Golja (co-author here) and
it changed the user that runs the python script.
Verification
Following the documentation I can successfully run the workflow.
Documentation
This commit only contains documentation update.