-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: add timeout for database query in workflow estimation to prevent blocking. #15116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Joibel
merged 11 commits into
argoproj:main
from
shuangkun:fix/estimation-db-query-timeout
Dec 16, 2025
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a9abaa9
fix: add timeout for database query in workflow estimation to prevent…
shuangkun b3e407d
fix: pass context to database query in GetWorkflowForEstimator
shuangkun 462350f
refactor: move timeout logic into GetWorkflowForEstimator
shuangkun 52d82e8
fix: test
shuangkun 718e75f
fix: test
shuangkun 1f9189f
fix: test
shuangkun d667c8e
Update persist/sqldb/workflow_archive.go
shuangkun a4afe16
fix: lint
shuangkun 61914bd
fix: use explicit context initialization with logger
shuangkun 3a15a81
fix: add nolint for contextcheck to suppress false positive
shuangkun a9fec7d
refactor: use TIMEOUT_SECONDS instead of time.Duration for estimation…
shuangkun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: lint
Signed-off-by: shuangkun <tsk2013uestc@163.com>
- Loading branch information
commit a4afe16f8215ef9e58d6ec9bdef773e36b200284
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.