chore: rename IsWorkflowDeleted to WorkflowExists for clarity #15146
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition was inverted - locks should be released when workflows are deleted, not when they exist. Changed from `!sm.isWFDeleted(wfKey)` to `sm.isWFDeleted(wfKey)`. This fixes a bug where locks for deleted workflows were not being released, potentially causing resource leaks. Signed-off-by: shuangkun <[email protected]>
Joibel
approved these changes
Dec 11, 2025
Joibel
added
area/mutex-semaphore
cherry-pick/3.6
Joibel
requested changes
Dec 11, 2025
Member
Joibel
left a comment
Joibel
left a comment
There was a problem hiding this comment.
isWFDeleted is really badly named.
In the non error case it returns exists which is true if the workflow exists, and false if it doesn't. So it returns the opposite of what you'd expect, so this logic is correct.
I'd appreciate a PR which renames that function, but I think the logic is correct, as the unit test shows.
The function was poorly named - it returns true when the workflow exists and false when it doesn't, which is the opposite of what the name suggests. This commit renames: - IsWorkflowDeleted type to WorkflowExists - isWFDeleted field to workflowExists - isWFDeleted variable to workflowExists The logic remains correct: locks are released when !workflowExists(wfKey), i.e., when the workflow doesn't exist (is deleted). Signed-off-by: shuangkun <[email protected]>
shuangkun
changed the title
Joibel
approved these changes
Dec 11, 2025
Joibel
removed
cherry-pick/3.6
guanguxiansheng
pushed a commit
to guanguxiansheng/argo-workflows
that referenced
this pull request
Dec 15, 2025
…oj#15146) Signed-off-by: shuangkun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition was inverted - locks should be released when workflows are deleted, not when they exist. Changed from
!sm.isWFDeleted(wfKey)tosm.isWFDeleted(wfKey).This fixes a bug where locks for deleted workflows were not being released, potentially causing resource leaks.
Motivation
Modifications
Verification
Documentation