fix: if pod fails without container termination, don't mark node succeeded always #15150
+157
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <[email protected]>
Joibel
added
area/controller
Joibel
changed the title
|
❌ Cherry-pick failed for 3.6. Please check the workflow logs for details. |
|
❌ Cherry-pick failed for 3.7. Please check the workflow logs for details. |
Joibel
added a commit
that referenced
this pull request
Dec 11, 2025
…eeded always (#15150) (cherry picked from commit 46b0ddd) Signed-off-by: Alan Clucas <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Dec 11, 2025
…eeded always (#15150) (cherry picked from commit 46b0ddd) Signed-off-by: Alan Clucas <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Dec 12, 2025
…eeded always (cherry-pick #15150 for 3.7) (#15155) Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Dec 12, 2025
…eeded always (cherry-pick #15150 for 3.7) (#15155) Signed-off-by: Alan Clucas <[email protected]> (cherry picked from commit d24f6b5)
Joibel
added a commit
that referenced
this pull request
Dec 12, 2025
…eeded always (cherry-pick #15150 for 3.6) (#15157) Signed-off-by: Alan Clucas <[email protected]>
guanguxiansheng
pushed a commit
to guanguxiansheng/argo-workflows
that referenced
this pull request
Dec 15, 2025
…eeded always (argoproj#15150) Signed-off-by: Alan Clucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
inferFailedReasondoesn't attempt to cope well with aFailedPod where the containers are not markedTerminated. We've seen this situation in the field - likely down to pod eviction.The current behaviour would eventually be to drop out the bottom of the function and return
NodeSucceededwhich feels quite optimistic for a failed pod.Modifications
Instead monitor whether both
waitandmainexited 0, if they did, then lets call this a Success, but otherwise return Failure telling the user that the pod has failed.Verification
Unit tests, but I don't know how to produce this usefully in e2e.
Documentation
None required.