Skip to content

fix: remove pod finalizer in abnormal scenarios #15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guanguxiansheng wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: remove pod finalizer in abnormal scenarios #15164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions workflow/controller/pod/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,8 @@ func (c *Controller) addPodEvent(ctx context.Context, pod *apiv1.Pod) {
if err != nil {
c.log.WithField("pod", pod.Name).Warn(ctx, "callback for pod add failed")
}
c.commonPodEvent(ctx, pod, false)
deleting := pod.DeletionTimestamp != nil
c.commonPodEvent(ctx, pod, deleting)
}

func (c *Controller) updatePodEvent(ctx context.Context, old *apiv1.Pod, newPod *apiv1.Pod) {
Expand All @@ -252,7 +253,8 @@ func (c *Controller) updatePodEvent(ctx context.Context, old *apiv1.Pod, newPod
if err != nil {
c.log.WithField("pod", newPod.Name).Warn(ctx, "callback for pod update failed")
}
c.commonPodEvent(ctx, newPod, false)
deleting := newPod.DeletionTimestamp != nil
c.commonPodEvent(ctx, newPod, deleting)
}

func (c *Controller) deletePodEvent(ctx context.Context, obj interface{}) {
Expand Down
Loading