-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: from mdspell to codespell #15149 #15167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gianarb
wants to merge
1
commit into
argoproj:main
Choose a base branch
from
ShippingBytes:chore/try-codespell
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| aks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,7 +166,7 @@ TOOL_SNIPDOC := $(HOME)/.local/bin/snipdoc | |
| # npm bin -g will do this on later npms than we have | ||
| NVM_BIN ?= $(shell npm config get prefix)/bin | ||
| TOOL_CLANG_FORMAT := /usr/local/bin/clang-format | ||
| TOOL_MDSPELL := $(NVM_BIN)/mdspell | ||
| TOOL_CODESPELL := /usr/bin/codespell | ||
| TOOL_MARKDOWN_LINK_CHECK := $(NVM_BIN)/markdown-link-check | ||
| TOOL_MARKDOWNLINT := $(NVM_BIN)/markdownlint | ||
| TOOL_DEVCONTAINER := $(NVM_BIN)/devcontainer | ||
|
|
@@ -830,16 +830,27 @@ docs/cli/argo.md: $(CLI_PKG_FILES) go.sum ui/dist/app/index.html hack/docs/cli.g | |
| docs/go-sdk-guide.md: $(TOOL_SNIPDOC) | ||
| $(TOOL_SNIPDOC) run | ||
|
|
||
| $(TOOL_MDSPELL): Makefile | ||
| # update this in Nix when upgrading it here | ||
| ifneq ($(USE_NIX), true) | ||
| npm list -g [email protected] > /dev/null || npm i -g [email protected] | ||
| endif | ||
|
|
||
| $(TOOL_CODESPELL): Makefile | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need for duplicate lines here, just put the dependencies on the same line as the target. |
||
|
|
||
| $(TOOL_CODESPELL): | ||
| ifeq (, $(shell which codespell)) | ||
| ifeq ($(shell uname),Darwin) | ||
| brew install codespell | ||
| else | ||
| sudo apt update | ||
| sudo apt install -y codespell | ||
| endif | ||
| endif | ||
|
|
||
| .PHONY: docs-spellcheck | ||
| docs-spellcheck: $(TOOL_MDSPELL) docs/metrics.md ## Spell check docs | ||
| docs-spellcheck: $(TOOL_CODESPELL) docs/metrics.md ## Spell check docs | ||
| # check docs for spelling mistakes | ||
| $(TOOL_MDSPELL) --ignore-numbers --ignore-acronyms --en-us --no-suggestions --report $(shell find docs -name '*.md' -not -name upgrading.md -not -name README.md -not -name fields.md -not -name workflow-controller-configmap.md -not -name upgrading.md -not -name executor_swagger.md -not -path '*/cli/*' -not -name tested-kubernetes-versions.md -not -name new-features.md) | ||
| $(TOOL_CODESPELL) --quiet-level=2 --check-filenames --ignore-words=.codespell-ignore --check-hidden "docs/**/*.md" | ||
| # alphabetize spelling file -- ignore first line (comment), then sort the rest case-sensitive and remove duplicates | ||
| $(shell cat .spelling | awk 'NR<2{ print $0; next } { print $0 | "LC_COLLATE=C sort" }' | uniq > .spelling.tmp && mv .spelling.tmp .spelling) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also remove these lines.