Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

fix: health status is set to healthy for statefulset with updateStrat… #136

Merged
mayzhang2000 merged 3 commits into from
Sep 1, 2020
Merged

fix: health status is set to healthy for statefulset with updateStrat… #136

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e8e505
fix: health status is set to healthy for statefulset with updateStrat…
mayzhang2000 Sep 1, 2020
2203bc8
fix: updated message
mayzhang2000 Sep 1, 2020
f8a4cb4
fix: added test
mayzhang2000 Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: updated message
  • Loading branch information
@mayzhang2000
mayzhang2000 committed Sep 1, 2020
commit 2203bc898dc79bb921bd8dc9fb5cd1d6f3b97230
2 changes: 1 addition & 1 deletion pkg/health/health.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ func getStatefulSetHealth(obj *unstructured.Unstructured) (*HealthStatus, error)
if sts.Spec.UpdateStrategy.Type == appsv1.OnDeleteStatefulSetStrategyType {
return &HealthStatus{
Status: HealthStatusHealthy,
Message: fmt.Sprintf("updateStrategy is OnDelete type."),
Message: fmt.Sprintf("statefulset has %d ready pods", sts.Status.ReadyReplicas),
Copy link

@glasser glasser May 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the issue that this change was fixing and it makes sense to me that this counts as "healthy", but what do folks think about iterating on this so that the message lets you know whether or not UpdatedReplicas matches Replicas in the OnDelete case?

Copy link

@thiagowfx thiagowfx Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#575

}, nil
}
if sts.Status.UpdateRevision != sts.Status.CurrentRevision {
Expand Down