This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Fix: improve error message when syncing resources to unmanaged namespaces #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashutosh16 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
ashutosh16
changed the title
aminerachyd
reviewed
Feb 10, 2025
| return nil, fmt.Errorf("Cluster level %s %q can not be managed when in namespaced mode", o.GetKind(), o.GetName()) | ||
| } else if o.GetNamespace() != "" && !c.managesNamespace(o.GetNamespace()) { | ||
| return nil, fmt.Errorf("Namespace %q for %s %q is not managed", o.GetNamespace(), o.GetKind(), o.GetName()) | ||
| return nil, fmt.Errorf("Destination namespace %q for resource kind %s %q is not managed by argocd", o.GetNamespace(), o.GetKind(), o.GetName()) |
There was a problem hiding this comment.
For more guidance, can we mention something like "go and edit cluster settings for X cluster" ?
Contributor
|
The gitops-engine repository is migrating to https://github.com/argoproj/argo-cd. Can you please update the PR by resolving the conflicts / If it's not relevant anymore, feel free to close it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : argoproj/argo-cd#11588
Signed-off-by: ashutosh16 [email protected]