Added data locations for function parameters and return parameters. #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chase1745
force-pushed
the
use-explicit-data-locations
branch
3 times, most recently
from
b43b852 to
b78046f
Compare
chase1745
force-pushed
the
use-explicit-data-locations
branch
from
b78046f to
5eb92cd
Compare
axic
approved these changes
Jun 26, 2018
…meters to comply with Solidity v0.5 making default data locations for parameters an error.
chriseth
force-pushed
the
use-explicit-data-locations
branch
from
ceec326 to
162d22c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added data locations for function parameters and function return parameters to comply with Solidity v0.5 making default data locations for parameters an error. (argotorg/solidity#4014)
All tests are passing locally.