Skip to content

Conversation

@stephen-slm
Copy link
Contributor

By exporting under the root, javascript importing modules will continue
to use it as expected without first having to index .default.

By exporting under the root, javascript importing modules will continue
to use it as expected without first having to index `.default.`
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.696% when pulling 8405162 on stephensli:fix/root-export-wrapped-solcjson into 46c59df on ethereum:master.

@ekpyron
Copy link
Collaborator

ekpyron commented Jan 26, 2022

Ok, since argotorg/solidity#12585 passes its tests relative to this change, I'm merging this, but @cameel and @axic should still have a look at it as well.

@ekpyron ekpyron merged commit c5aae68 into argotorg:master Jan 26, 2022
@stephen-slm stephen-slm deleted the fix/root-export-wrapped-solcjson branch January 26, 2022 11:19
@cameel
Copy link
Collaborator

cameel commented Jan 26, 2022

Looks like this PR was enough to make it work with Truffle. For me it still fails with Hardhat though. That's because of the dist/ directory that's now in the package.

I rebased #594 on top of this and all its tests should be passing if things are fixed. The truffle ones just need further adjustments so please ignored them until I fix them but I think the issue in the Hardhat ones is real.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants