Build release build on tags. #10070
Merged
Build release build on tags. #10070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
buildReleaseOnTags
branch
from
0a2981d to
91fc130
Compare
leonardoalt
reviewed
Oct 19, 2020
| cd $WORKSPACE | ||
|
|
||
| # shellcheck disable=SC2166 | ||
| if [[ "$CIRCLE_BRANCH" == release -o -n "$CIRCLE_TAG" -o -n "$FORCE_RELEASE" -o "$(git tag --points-at HEAD 2>/dev/null)" == v* ]] |
There was a problem hiding this comment.
Will this work with these CIRCLE vars?
chriseth
force-pushed
the
buildReleaseOnTags
branch
from
91fc130 to
3217b6a
Compare
leonardoalt
reviewed
Oct 19, 2020
| cd $WORKSPACE | ||
|
|
||
| # shellcheck disable=SC2166 | ||
| if [[ "$CIRCLE_BRANCH" = release || -n "$CIRCLE_TAG" || -n "$FORCE_RELEASE" || "$(git tag --points-at HEAD 2>/dev/null)" == v* ]] |
There was a problem hiding this comment.
The other scripts don't seem to have the git part. Why add here and not there?
Contributor
Author
There was a problem hiding this comment.
I took that from a third script, and I think it is a good idea so that it also works locally.
leonardoalt
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10067