Skip to content

Compatibility fixes for solc-js TypeScript migration #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekpyron merged 5 commits into from
Jan 26, 2022
Merged

Compatibility fixes for solc-js TypeScript migration #12583

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1cd4ffc
bytecode compare: Stop depending on solc-js internal structure and in…
cameel Jan 25, 2022
8011d23
Release checklist: switch to a command that automatically downloads t…
cameel Jan 25, 2022
cdaa6dd
Adjust workflow with solc-js checkout now that it's on TypeScrpt
cameel Jan 25, 2022
4e39513
Changelog entry for the TypeScript migration
cameel Jan 25, 2022
f46e333
fixup! bytecode compare: Stop depending on solc-js internal structure…
cameel Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! bytecode compare: Stop depending on solc-js internal structure… 
… and install it via npm from a local dir instead
  • Loading branch information
@cameel @ekpyron
cameel authored and ekpyron committed Jan 26, 2022
commit f46e333f9a0b4be44c192adddffe04bd64f8b383
9 changes: 8 additions & 1 deletion scripts/bytecodecompare/storebytecode.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,18 @@ TMPDIR=$(mktemp -d)

if [[ "$SOLC_EMSCRIPTEN" = "On" ]]
then
echo "Installing solc-js..."
# npm install solc
git clone --depth 1 https://github.com/ethereum/solc-js.git solc-js
cp "$REPO_ROOT/emscripten_build/libsolc/soljson.js" solc-js/
pushd solc-js/
npm install
npm run build
popd

cp "$REPO_ROOT/scripts/bytecodecompare/prepare_report.js" .
( npm install solc-js/ )
npm install solc-js/

echo "Running the compiler..."
# shellcheck disable=SC2035
./prepare_report.js *.sol > report.txt
Expand Down