-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Introduce pragma experimental solidity
#14168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf299e4 to
57c3e8b
Compare
pragma experimental solidity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the changelog phrasing and would still change the flag name and not always emit it in the json AST, but only when it's true.
Apart from that mostly optional comments and almost good to go.
Testing is good enough (if you want, you can still add tests for it occurring twice in the beginning and once in the beginning plus once later on - but since that's all covered by the preexisting logic, it's also fine if not - the same goes for the experimental flag in CBOR metadata: could be tested specifically, but it's already tested for any experimental pragma, so also fine)
r0qs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some questions :)
@ekpyron precisely why I didn't add such tests, as they would be completely redundant, i.e. adding them for |
619fc81 to
97df8a8
Compare
97df8a8 to
8220f35
Compare
test/libsolidity/syntaxTests/pragma/experimental_solidity_out_of_order_1.sol
Outdated
Show resolved
Hide resolved
ekpyron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor adjustments - if you fix the comments above and squash, we can merge today.
Also needs a rebase, though, and the Changelog entries needs to move to 0.8.21.
8220f35 to
b1718e7
Compare
b1718e7 to
6d35235
Compare
test/libsolidity/syntaxTests/pragma/experimental_solidity_out_of_order_2.sol
Outdated
Show resolved
Hide resolved
6d35235 to
363a76f
Compare
test/libsolidity/syntaxTests/pragma/experimental_solidity_out_of_order_2.sol
Show resolved
Hide resolved
363a76f to
3e88419
Compare
ekpyron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cosmetics left, if you please, but generally good to merge.
Exclude pragma experimental error from ANTLR tests Test for first pragma after non-pragma declaration Resolve import pragmas Change pragma name from next to solidity Add Changelog entries Address review comments
3e88419 to
8a41f4a
Compare
Note: this is still a work in progress
next) (decisionpragma experimental solidity)nexttosolidityFixes: #10639 (comment)