Skip to content

Import/namespace and test extension handling cleanup in soltest #16013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cameel wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Import/namespace and test extension handling cleanup in soltest #16013

cameel wants to merge 3 commits into from
+144 −125

Conversation

@cameel
Copy link
Collaborator

@cameel cameel commented Apr 19, 2025

Depends on #16012.

This is a bunch of refactors I extracted from #16012:

  • We have lists of test file extensions hard-coded in two places, which is error-prone. The PR unifies them.
  • Removal of unused imports in files where I spotted them.
  • In some places we use the annoying, verbose solidity::test:: prefix for CommonOptions and other things, in others we don't. Often we do both in the same file. This PR removes it.

It's a pure refactor, there are no functionality changes.

@cameel cameel added testing 🔨 has dependencies The PR depends on other PRs that must be merged first refactor labels Apr 19, 2025
@cameel cameel requested review from aarlt and r0qs April 19, 2025 07:43
@cameel cameel self-assigned this Apr 19, 2025
@cameel cameel mentioned this pull request Apr 19, 2025
Draft
@cameel cameel force-pushed the evmasm-test-case branch 2 times, most recently from 1fd7f7d to ce8ca0a Compare April 19, 2025 08:11
@cameel cameel force-pushed the soltest-cleanup branch 2 times, most recently from 58795c7 to ed948c6 Compare April 23, 2025 02:10
@cameel cameel force-pushed the evmasm-test-case branch 2 times, most recently from f1723b6 to fe39551 Compare April 23, 2025 19:16
Base automatically changed from evmasm-test-case to develop April 23, 2025 19:57
@cameel cameel marked this pull request as ready for review April 25, 2025 06:13
@github-actions
Copy link

github-actions bot commented May 9, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 9, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label May 10, 2025
@github-actions
Copy link

github-actions bot commented May 25, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 25, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label May 26, 2025
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 9, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 13, 2025
@github-actions
Copy link

github-actions bot commented Jun 27, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 13, 2025
@github-actions
Copy link

github-actions bot commented Jul 28, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 28, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 28, 2025
@github-actions
Copy link

github-actions bot commented Aug 12, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 12, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 14, 2025
@github-actions
Copy link

github-actions bot commented Aug 29, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 29, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 13, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 13, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 17, 2025
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 2, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 5, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 20, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 8, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Nov 8, 2025
appletorsh19-stack added a commit to appletorsh19-stack/solidity that referenced this pull request Nov 9, 2025
@appletorsh19-stack
Delete docs/using-the-com۱piler.rst
e2ea089 
argotorg#16013 
argotorg#15937 
#create empity workspse s 
argotorg#14417 
argotorg#3746 
argotorg#955 
argotorg#10072 
argotorg#14291 
#delete all ol file s
@appletorsh19-stack appletorsh19-stack mentioned this pull request Nov 9, 2025
Closed
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 23, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Dec 10, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0qs r0qs Awaiting requested review from r0qs

@aarlt aarlt Awaiting requested review from aarlt

At least 1 approving review is required to merge this pull request.

Assignees

@cameel cameel

Labels

has dependencies The PR depends on other PRs that must be merged first refactor testing 🔨

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cameel