-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Move test tools to the subdirectory test/tools and adjust CMakeLists #3708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@chfast can you double check this? |
|
This is quite hackish. I'd recommend following independent changes:
|
|
@chfast's suggestions are always good :) In the medium term, we should also remove the globs in the other CMake files. |
|
OK - the previous solution was hackish as well, but this is indeed a good opportunity to clean it up at least somewhat. Moving the solfuzzer target to a CMakeLists.txt in a subdirectory changes its path in the build directory, though - I hope I caught all uses of solfuzzer in the scripts and adjusted them correctly. Actually I'd usually prefer listing all files individually in CMakeLists.txt, since any globbing (recursive or not) may result in build failures for example if new files are added and cmake is not run again afterwards - but this is actually a separate discussion and so far globbing seems to be used everywhere. |
|
squashed |
chfast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks better now.
I'm also for not using GLOB, but it's usually quite a lot of work to replace GLOBs if they were used. That's not for this PR.
Adding files to a single target also can be split into dirs using target_sources().
|
I was wondering if it should be moved out of |
Came up as part of #3674 when adding new test tools.