Only consider files ending with .sol and not starting with ~ in synta… #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
force-pushed
the
syntaxTestsExtensions
branch
from
8395da9 to
df39015
Compare
chriseth
suggested changes
Mar 16, 2018
Contributor
chriseth
left a comment
chriseth
left a comment
There was a problem hiding this comment.
Please reduce code duplication.
test/libsolidity/SyntaxTest.cpp
Outdated
| fs::directory_iterator() | ||
| )) | ||
| numTestsAdded += registerTests(*sub_suite, _basepath, _path / entry.path().filename()); | ||
| if ( |
Contributor
There was a problem hiding this comment.
Please format as
if (fs::is_directory(entry.path()) || (
... &&
))
``
test/libsolidity/SyntaxTest.cpp
Outdated
| if ( | ||
| fs::is_directory(entry.path()) || | ||
| (entry.path().extension().string() == ".sol" && | ||
| !boost::starts_with(entry.path().filename().string(), "~")) |
Contributor
There was a problem hiding this comment.
Hm, I thought about excluding files that start with ..
ekpyron
force-pushed
the
syntaxTestsExtensions
branch
from
df39015 to
e68c19c
Compare
Collaborator
Author
|
@chriseth Requested changes done: moved filename filter to a static function in SyntaxTest; also filter files starting with ".". Code formatting request becomes obsolete. |
chriseth
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x tests.
Fixes #3742.
Are there any other naming schemes for temporary files that will still result in temporary files being considered valid tests?