Do not use fork of openzeppelin anymore

[axic]

Depends on OpenZeppelin/openzeppelin-contracts#1498

[chriseth]

Fails.

[nventuro]

Hey @axic, I noticed your build is failing because of the breaking changes introduced in 0.5.0 (e.g. the data location for certain types now being mandatory). I was actually tracking that in this OpenZeppelin PR, and we even have an issue for this whole thing: OpenZeppelin/openzeppelin-contracts#1211.

What do you think about having a branch in OpenZeppelin that compiles using nightly builds, instead of you having to maintain your own fork? That way we could give you a hand maintaining, making sure the branch gets updated often to reflect the latest changes, and it'd also make it easier for us to upgrade to the latest version once its released.

[chriseth]

@nventuro that would be wonderful! Do you already have such a branch?

[nventuro]

I just created the solc-nightly branch, from master, and set the CI to only use the nightly compiler. To bring that branch up to date with 0.5.0, we should open PRs against it: we already have a couple from a while back (OpenZeppelin/openzeppelin-contracts#1068 and OpenZeppelin/openzeppelin-contracts#1144).

[chriseth]

Will you make the updates? You know about https://github.com/axic/openzeppelin-solidity/tree/solidity-050 do you?

[axic]

You know about https://github.com/axic/openzeppelin-solidity/tree/solidity-050 do you?

The problem is we haven't merged upstream changes to it for 3 months. We could do that, but I think merging these 2 new PRs will be faster.

[chriseth]

No reason to keep this open.

[axic]

Zeppelin has released their 0.5.0-compatible version: https://github.com/OpenZeppelin/openzeppelin-solidity/releases/tag/v2.1.1 Updating it here.

[axic]

This works now.