Skip to content

[Yul] Fix registration of functions in scopes. #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriseth merged 5 commits into from
Apr 5, 2019
Merged

[Yul] Fix registration of functions in scopes. #6456

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d20b3c9
Function grouper is a requirement for the VarNameCleaner.
chriseth Apr 4, 2019
054c16a
[Yul] Fix registration of functions in scopes.
chriseth Apr 2, 2019
0d2ae84
Use move semantics.
chriseth Apr 4, 2019
1be3882
Test shadowing between variables inside and outside of functions.
chriseth Apr 4, 2019
804c155
Changelog entry.
chriseth Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test shadowing between variables inside and outside of functions.
  • Loading branch information
@chriseth
chriseth committed Apr 5, 2019
commit 1be3882ade5e8dd71a3adaa48e84f2f2b60b013d
6 changes: 6 additions & 0 deletions test/libyul/Parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,12 @@ BOOST_AUTO_TEST_CASE(switch_duplicate_case_different_literal)
BOOST_CHECK(successParse("{ switch 1:u256 case \"1\":u256 {} case \"2\":u256 {} }"));
}

BOOST_AUTO_TEST_CASE(function_shadowing_outside_vars)
{
CHECK_ERROR("{ let x:u256 function f() -> x:u256 {} }", DeclarationError, "already taken in this scope");
BOOST_CHECK(successParse("{ { let x:u256 } function f() -> x:u256 {} }"));
}

BOOST_AUTO_TEST_CASE(builtins_parser)
{
struct SimpleDialect: public Dialect
Expand Down