Upgrade json-cpp to 1.9.3. #9383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
force-pushed
the
updateJsonCpp
branch
2 times, most recently
from
df3c999 to
619e447
Compare
axic
approved these changes
Jul 10, 2020
Contributor
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Looks okay to me, but perhaps wait for another review.
Collaborator
Author
|
There shouldn't be any harm in doing this and I double checked that there's no mention of 1.9.2 left in the repo, so I think I'll go ahead merging this, once CI finishes, so that @aarlt can better proceed. |
resonant-riches
added a commit
to ChorusOne/azimuth-cli
that referenced
this pull request
Mar 4, 2024
Hopefully fix compiler errors on Clang on Apple Silicon. Patches are based on the following upstream PRs: argotorg/solidity#4160 argotorg/solidity#4235 argotorg/solidity#4470 argotorg/solidity#5699 argotorg/solidity#7268 argotorg/solidity#7827 argotorg/solidity#9383 argotorg/solidity#14725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release notes read generally favorable: https://github.com/open-source-parsers/jsoncpp/releases
And json-cpp 1.9.2 is slower to build and causing issues with clang-10 and the ossfuzz builds, stalling the docker image work of @aarlt.