feat: add palette file, add palette tests #566
Conversation
|
|
argyleink
left a comment
argyleink
left a comment
There was a problem hiding this comment.
❤️ thanks for this!
you've got the files in there, and the tests look like they'll pass, but the one forgotten part was to add them to the main bundle and main JS object.
|
I've added a palette playground now! I kept it really sparse in terms of info. The basic concept is there but I mean there could be essays written, so didn't wanna do too much before you had a look at it. Sorry for some formatting changes, I wrestled with trying to get the formatter to stop but idk, it didn't change anything at least 😅 Had to edit slider.js so I could use negative values in the hue rotation slider. |
argyleink
left a comment
argyleink
left a comment
There was a problem hiding this comment.
the playground works great, nice port!
this all looks ready to merge to me except for the SVG file changes to props.js. hard to filter out exactly what else changed since the formatter edited so much, but all good. restore those 2 little lines and this is g2g!?
| import Easings from '../src/props.easing.js' | ||
| import Gradients from '../src/props.gradients.js' | ||
| import Shadows from '../src/props.shadows.js' | ||
| import SVG from '../src/props.svg.js' |
There was a problem hiding this comment.
Sorry, old habit 🤦 I was adding the palette and just saw it was unused. Will restore it! 👍
2 participants
I'm not sure if the tests are used anymore, they are missing some stuff so I could remove that part of the PR (or fix them) - I didn't put much work into it before checking with you.
Step 2 in this PR is for sure the documentation, or it could be a completely new PR.