Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 6, 2025

The playground was generating interceptors for nested SelectExpr calls when only the outermost should generate one, and incorrectly typed nested collection properties as ItemDto instead of IEnumerable<ItemDto>.

Changes

Core Infrastructure

  • Added IsNestedInsideAnotherSelectExpr() to SelectExprHelper - walks syntax tree to detect nesting

Playground

  • Updated CodeGenerationService.IsSelectExprInvocation() to skip nested calls using shared helper

Source Generator

  • Refactored SelectExprGenerator.IsSelectExprInvocation() to use shared helper, removing duplicate logic

Tests

  • Added NestedSelectExprTypeTest - verifies correct IEnumerable<TDto> type generation
  • Added Issue_NestedSelectExprConsistencyTest - validates single interceptor and correct conversion

Example

query.SelectExpr<Entity, EntityDto>(x => new
{
    x.Id,
    ItemTitles = x.Items.SelectExpr<Item, ItemDto>(i => new { i.Title }),
});

Before: Generated two interceptors; ItemTitles typed as ItemDto
After: Generates one interceptor; inner SelectExpr converts to .Select(); ItemTitles typed as IEnumerable<ItemDto>

Original prompt

This section details on the original issue you should resolve

<issue_title>bug: When there is a nested SelectExpr, the output in Playground does not match the actual generated result</issue_title>
<issue_description>## Repro

using System;
using System.Linq;
using System.Collections.Generic;
namespace MinRepro;

public class Program
{
    public void Execute()
    {
        var data = new List<Entity>();
        var query = data.AsQueryable();
        // Reproduce your issue here
        var result = query.SelectExpr<Entity, EntityDto>(x => new
        {
            x.Id,
            x.Name,
            ChildDescription = x.Child?.Description,
            ItemTitles = x.Items.SelectExpr<Item, ItemDto>(i => new {i.Title}),
        });
    }
}

// here are some sample classes to work with 
public class Entity
{
    public int Id { get; set; }
    public string Name { get; set; } = "";
    public Child? Child { get; set; }
    public List<Item> Items { get; set; } = [];
}

public class Child
{
    public string Description { get; set; } = "";
}

public class Item
{
    public string Title { get; set; } = "";
}

Actual

in real

// <auto-generated>
// This file is auto-generated by Linqraft.
//   Linqraft Version  : 0.7.0-alpha.8+19d8834e72
//   Linqraft Build at : 2025-12-06 21:57:55
//   Code Generated at : 2025-12-06 22:47:27
// </auto-generated>
#nullable enable
#pragma warning disable IDE0060
#pragma warning disable CS8601
#pragma warning disable CS8602
#pragma warning disable CS8603
#pragma warning disable CS8604
#pragma warning disable CS8618
using System;
using System.Linq;
using System.Collections.Generic;
using System.Collections.Immutable;
namespace Linqraft
{
    file static partial class GeneratedExpression
    {
        /// <summary>
        /// generated select expression method EntityDto (explicit) <br/>
        /// at Program.cs(14,28)
        /// </summary>
        [global::System.Runtime.CompilerServices.InterceptsLocationAttribute(1, "vFxqDeERynAiImVfoKmsVB8BAABQcm9ncmFtLmNz")]
        public static IQueryable<TResult> SelectExpr_FF795AB1_553BA9DB<TIn, TResult>(
            this IQueryable<TIn> query, Func<TIn, object> selector)
        {
            var matchedQuery = query as object as IQueryable<global::MinRepro.Entity>;
            var converted = matchedQuery.Select(x => new global::MinRepro.EntityDto
            {
                Id = x.Id,
                Name = x.Name,
                ChildDescription = x.Child != null ? (string?)x.Child.Description : null,
                ItemTitles = x.Items
                    .Select(i => new global::MinRepro.ItemDto
                    {
                        Title = i.Title
                    })
            });
            return converted as object as IQueryable<TResult>;
        }

    }
}
namespace MinRepro
{
    /// <remarks>
    /// From: <c>Item</c>
    /// </remarks>
    public partial class ItemDto
    {
        /// <remarks>
        /// From: <c>Item.Title</c>
        /// </remarks>
        public required string Title { get; set; }
    }

    /// <summary>
    /// here are some sample classes to work with
    /// </summary>
    /// <remarks>
    /// From: <c>Entity</c>
    /// </remarks>
    public partial class EntityDto
    {
        /// <remarks>
        /// From: <c>Entity.Id</c>
        /// </remarks>
        public required int Id { get; set; }
        /// <remarks>
        /// From: <c>Entity.Name</c>
        /// </remarks>
        public required string Name { get; set; }
        /// <remarks>
        /// From: <c>Entity.Child?.Description</c>
        /// </remarks>
        public required string? ChildDescription { get; set; }
        /// <remarks>
        /// From: <c>Entity.Items.SelectExpr&lt;Item,ItemDto&gt;(i=&gt;new{i.Title})</c>
        /// </remarks>
        public required global::System.Collections.Generic.IEnumerable<MinRepro.ItemDto> ItemTitles { get; set; }
    }
}

in playground

// expression
using System;
using System.Linq;
using System.Collections.Generic;
namespace Linqraft
{
    file static partial class GeneratedExpression
    {
        /// <summary>
        /// generated select expression method EntityDto (explicit) <br/>
        /// at Program.cs(13,28)
        /// </summary>
        [global::System.Runtime.CompilerServices.InterceptsLocationAttribute(1, "uBbZSspQHldj+5NRaGts/B4BAABQcm9ncmFtLmNz")]
        public static IQueryable<TResult> SelectExpr_620CA1C9_0B30C4CE<TIn, TResult>(
            this IQueryable<TIn> query, Func<TIn, object> selector)
        {
            var matchedQuery = query as object as IQueryable<global::MinRepro.Entity>;
            var converted = matchedQuery.Select(x => new global::MinRepro.EntityDto
            {
                Id = x.Id,
                Name = x.Name,
                ChildDescription = x.Child != null ? (string)x.Child.Description : null,
                ItemTitles = x.Items
                   ...

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes arika0093/Linqraft#220

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Fix nested SelectExpr output in Playground Fix nested SelectExpr inconsistency between playground and source generator Dec 6, 2025
Copilot AI requested a review from arika0093 December 6, 2025 14:15
@arika0093 arika0093 marked this pull request as ready for review December 6, 2025 14:46
@arika0093 arika0093 merged commit a25737e into main Dec 6, 2025
4 checks passed
@arika0093 arika0093 deleted the copilot/fix-nested-selectexpr-output branch December 6, 2025 14:56
arika0093 added a commit that referenced this pull request Dec 10, 2025
…erator (#221)

* Initial plan

* Add shared IsNestedInsideAnotherSelectExpr helper and use in playground and source generator

Co-authored-by: arika0093 <[email protected]>

* Add comprehensive tests for nested SelectExpr consistency fix

Co-authored-by: arika0093 <[email protected]>

* Remove tests for nested SelectExpr type verification

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: arika0093 <[email protected]>
Co-authored-by: Arika Ishinami <[email protected]>
(cherry picked from commit a25737e)
@arika0093 arika0093 mentioned this pull request Dec 10, 2025
arika0093 added a commit that referenced this pull request Dec 10, 2025
* Fix: Remove parent class nesting from implicit DTOs in hash namespaces (#219)

* Initial plan

* Add test for issue: implicit DTOs should not be nested in parent class when using hash namespace

Co-authored-by: arika0093 <[email protected]>

* Fix: Implicit DTOs should not be nested in parent class when using hash namespace

Co-authored-by: arika0093 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: arika0093 <[email protected]>
(cherry picked from commit dd2d380)

* Fix nested SelectExpr inconsistency between playground and source generator (#221)

* Initial plan

* Add shared IsNestedInsideAnotherSelectExpr helper and use in playground and source generator

Co-authored-by: arika0093 <[email protected]>

* Add comprehensive tests for nested SelectExpr consistency fix

Co-authored-by: arika0093 <[email protected]>

* Remove tests for nested SelectExpr type verification

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: arika0093 <[email protected]>
Co-authored-by: Arika Ishinami <[email protected]>
(cherry picked from commit a25737e)

* docs: Add IntroductionSection component and improve accessibility (#223)

* feat: add IntroductionSection component for query-based DTO generation

* fix: add translate attribute to improve accessibility in playground components

* refactor: remove custom animation definitions from tailwind.css

(cherry picked from commit 2a039c0)

* Fix nested SelectExpr code generation: parent class qualification, array types, and comment verbosity (#222)

* Initial plan

* Initial analysis of nested SelectExpr issues

Co-authored-by: arika0093 <[email protected]>

* Fix Issues 1 and 3 for nested SelectExpr - Issue 2 still in progress

Co-authored-by: arika0093 <[email protected]>

* Fix Issue 2 - array property types now correctly include [] suffix

Co-authored-by: arika0093 <[email protected]>

* Refactor array type detection into helper method per code review

Co-authored-by: arika0093 <[email protected]>

* Address PR review comments: rename test file, remove qualifiers with partial declarations, improve comments, extract method

Co-authored-by: arika0093 <[email protected]>

* Clarify that partial class declarations are required for nested DTO generation

Co-authored-by: arika0093 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: arika0093 <[email protected]>
(cherry picked from commit a163791)

* docs: separate README contents to other files (#224)

(cherry picked from commit 29b0301)

* Fix: set default value of settingsExpanded to false in Sidebar component

(cherry picked from commit a34d686)

* docs: add comprehensive documentation for Nested SelectExpr feature

(cherry picked from commit 97439c9)

* Revert "docs: add comprehensive documentation for Nested SelectExpr feature"

This reverts commit 97439c9.

(cherry picked from commit 755698c)

* docs: add Nested SelectExpr documentation for reusable DTOs (#225)

* docs: add Nested SelectExpr documentation for reusable DTOs

* docs: update Nested SelectExpr documentation with important notes and usage requirements

* upd

* Fix GitHub Issue link in nested-selectexpr.md

(cherry picked from commit 64b9787)

* fix: NestedSelectExprTest and update documentation (#229)

* Fix: update Issue207_NestedSelectExprTest to support partial classes and remove .NET 9 specific warnings

* Fix: update documentation for Nested SelectExpr to clarify beta status and remove .NET 9+ recommendation

(cherry picked from commit 1aa5ec7)

* Document explicit class naming for nested DTOs

Added section on explicit class naming in nested DTOs.

(cherry picked from commit 1ddc079)

* Enhance library comparison with GitHub stars

Updated the library comparison table to include GitHub repository star counts for each library.

(cherry picked from commit d875f80)

* Update Docs link to point to library directory

(cherry picked from commit 59498e4)

* Refactor Order example to use records and facets

Updated the example to use records and facets for Order and OrderChild.

(cherry picked from commit c66f8b8)

* Add pre-built expression tree caching for IQueryable operations (#234)

* Initial plan

* Add pre-built expression tree configuration and implementation

- Added LinqraftUsePrebuildExpression configuration option (default: false)
- Created ExpressionTreeBuilder helper class for generating cached expression fields
- Updated SelectExprInfoAnonymous to use pre-built expressions when enabled
- Updated SelectExprInfoNamed to use pre-built expressions when enabled
- Updated SelectExprInfoExplicitDto to use pre-built expressions when enabled
- Pre-built expressions only apply to IQueryable (not IEnumerable)
- Pre-built expressions are disabled when captures are used

Co-authored-by: arika0093 <[email protected]>

* Refactor static field generation to class level

- Moved static field generation from method body to class level
- Added GenerateStaticFields() virtual method to SelectExprInfo
- Updated SelectExprGroups to collect and pass static fields
- Updated GenerateSourceCodeSnippets to output static fields before methods
- Fixed null reference warning in SelectExprGroups

Co-authored-by: arika0093 <[email protected]>

* Complete pre-built expression tree implementation

- Fixed CompilerVisibleProperty list to include LinqraftUsePrebuildExpression
- Anonymous types cannot use pre-built expressions (result type is compiler-generated)
- Pre-built expressions only work for named/predefined/explicit DTO types
- Added comprehensive tests for IQueryable with different DTO patterns
- All tests passing with pre-built expressions enabled

Co-authored-by: arika0093 <[email protected]>

* Add LinqraftUsePrebuildExpression to all CompilerVisibleProperty lists

- Updated examples/Directory.Build.props with new configuration property
- Fixed playground/Services/CodeGenerationService.cs to use updated API signature
- All projects now support the new LinqraftUsePrebuildExpression configuration

Co-authored-by: arika0093 <[email protected]>

* Add LinqraftUsePrebuildExpression property to project files

* Fix code generation issues per review feedback

- Use 'var' instead of explicit type in expression initialization (line 93)
- Remove unnecessary '!' null-forgiving operator when fieldName is not null
- Fix indentation of generated multi-line lambda expressions
- Use explicit Expression<> type instead of 'as' operator (lambdas cannot use 'as')

Co-authored-by: arika0093 <[email protected]>

* Refactor to use direct expression initialization per review feedback

- Updated documentation in global-properties.md for LinqraftUsePrebuildExpression
- Added note about captures not supporting pre-built expressions
- Refactored ExpressionTreeBuilder to directly initialize expression fields (no lazy init)
- Removed GenerateNamedExpressionTreeInitialization and GenerateAnonymousExpressionTreeInitialization
- Expression trees now initialized at field declaration, eliminating null checks
- Updated SelectExprInfoNamed and SelectExprInfoExplicitDto to use new approach
- Added test for multiple DTO types to verify pre-built expressions work correctly
- All 6 tests passing

Co-authored-by: arika0093 <[email protected]>

* Address final review feedback: readonly, indentation, remove test, add playground toggle

- Added 'readonly' keyword to static expression fields for immutability
- Fixed indentation: ensured proper line ending with AppendLine for multi-line expressions
- Deleted Linqraft.Tests.Configuration project as requested
- Removed project reference from Linqraft.slnx
- Added toggle for LinqraftUsePrebuildExpression in playground Settings section
- All tests passing (130/130)

Co-authored-by: arika0093 <[email protected]>

* revert: reset Linqraft.Tests.Configuration

* Fix indentation in BuildExprCodeSnippets for static fields

* Add static fields generation to expression code snippets

* formatt

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: arika0093 <[email protected]>
Co-authored-by: Arika Ishinami <[email protected]>
(cherry picked from commit 1761753)

* chore(deps): bump stefanzweifel/git-auto-commit-action from 4 to 7 (#236)

Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 4 to 7.
- [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases)
- [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md)
- [Commits](stefanzweifel/git-auto-commit-action@v4...v7)

---
updated-dependencies:
- dependency-name: stefanzweifel/git-auto-commit-action
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 107f2d2)

* Bump AutoMapper from 15.1.0 to 16.0.0 (#237)

---
updated-dependencies:
- dependency-name: AutoMapper
  dependency-version: 16.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 623b9fa)

* feat: optimize DTO generation and performance documentation (#235)

* Refactor GenerateDtoClasses method for improved readability and performance

* Add caching for pre-built expressions in SelectExprInfoNamed

* Refactor nullable access conversion to simplify default value handling

* Update performance documentation to clarify benchmarks and improve readability

* Update README to simplify performance and FAQ sections

* Fix nullable type handling in GetDefaultValueForType method

(cherry picked from commit 54005a1)

* formatted

(cherry picked from commit 11122cb)

* chore: update commit message format for csharpier workflow

(cherry picked from commit 735eb9f)

* playground: enable ScrollBeyondLastLine and update StickyScroll options in EditorPane and PreviewPane

(cherry picked from commit 9bc3057)

* Deduplicate DTO class definitions globally across all generated files (#240)

* Initial plan

* Fix duplicate ChildDto generation for same-shaped nested DTOs in Select expressions

Co-authored-by: arika0093 <[email protected]>

* Improve code comments based on review feedback

Co-authored-by: arika0093 <[email protected]>

* Fix duplicate DTO class definitions by deduplicating at generation point

Reverted changes to DtoProperty.cs and implemented deduplication in
GenerateSourceCodeSnippets.BuildDtoCodeSnippetsGroupedByNamespace instead.
This ensures DTOs with the same FullName (namespace + class name) are only
generated once, even when used across multiple SelectExpr calls.

Co-authored-by: arika0093 <[email protected]>

* Implement global DTO deduplication across all files

- Collect all DTOs from all SelectExpr groups
- Deduplicate globally by FullName before generation
- Generate all DTOs in a single shared GeneratedDtos.g.cs file
- Each expression group file now only contains expression methods
- This ensures DTOs are not duplicated even when used across different files

Co-authored-by: arika0093 <[email protected]>

* Refactor DTO generation based on code review feedback

- Moved global DTO deduplication logic to GenerateSourceCodeSnippets.BuildGlobalDtoCodeSnippet
- Separated SelectExprGroups.GenerateCode into two methods: GenerateCode and GenerateCodeWithoutDtos
- Made GenerateCommentHeaderPart and GenerateHeaderFlagsPart public for cross-namespace use
- Renamed test files to Issue239_* pattern for clarity
- Updated playground CodeGenerationService to use new global DTO deduplication
- Fixed null reference warning in playground service

Co-authored-by: arika0093 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: arika0093 <[email protected]>
(cherry picked from commit 16b287e)

* refactor: DTO handling and improve code clarity (#216)

* refactor: improve code structure and add documentation for auto-generated DTO attribute

* refactor: rename ExportAll method to ExportAllConstantSnippets for clarity

* refactor: replace hardcoded DTO attributes with a dedicated method for better maintainability

* refactor: add EditorBrowsable attribute to internal DTO attributes for better visibility control

(cherry picked from commit ae2ba5f)

* fix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: arika0093 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: When there is a nested SelectExpr, the output in Playground does not match the actual generated result

2 participants