Skip to content

Fix sparsepoly duplicate terms #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
woojucy wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix sparsepoly duplicate terms #954

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a3fb3b4
Update CHANGELOG: Fix handling of duplicate terms in SparsePolynomial
woojucy Jan 4, 2025
f1d4d22
Add pre-validation to SparsePolynomial construction
woojucy Mar 1, 2025
8148bb2
Update poly/src/polynomial/univariate/sparse.rs
woojucy Mar 1, 2025
887dd95
Update poly/src/polynomial/univariate/sparse.rs
woojucy Mar 1, 2025
09f73e8
Update CHANGELOG.md
woojucy Mar 1, 2025
93f8bfa
Update poly/src/polynomial/univariate/sparse.rs
woojucy Mar 1, 2025
a312f6f
Update poly/src/polynomial/univariate/sparse.rs
woojucy Mar 1, 2025
f8781e7
Update poly/src/polynomial/univariate/sparse.rs
woojucy Mar 1, 2025
91526ec
Add tests for is_valid_coefficients_vec
woojucy Mar 1, 2025
ca42a3c
Add sorting support to is_valid_coefficients_vec
woojucy Mar 1, 2025
4fb38c5
Merge branch 'arkworks-rs:master' into fix_sparsepoly_duplicate_terms
woojucy Mar 12, 2025
06bfae5
Resolve merge conflicts
woojucy Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Resolve merge conflicts
  • Loading branch information
@woojucy
woojucy committed Mar 12, 2025
commit 06bfae557d563f22aef898dae3d1ef34e97737d5
3 changes: 1 addition & 2 deletions poly/src/polynomial/univariate/sparse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ pub enum CoeffVecError {
}

impl<F: Field> SparsePolynomial<F> {

// Function to validate that the input coefficient vector is simplified
pub fn is_valid_coefficients_vec(coeffs: &mut [(usize, F)]) -> Result<(), CoeffVecError> {
coeffs.sort_by(|a, b| a.0.cmp(&b.0));
Expand All @@ -257,7 +256,7 @@ impl<F: Field> SparsePolynomial<F> {
}
Ok(())
}

/// Constructs a new polynomial from a list of coefficients.
pub fn from_coefficients_slice(coeffs: &[(usize, F)]) -> Self {
Self::from_coefficients_vec(coeffs.to_vec())
Expand Down
Loading