-
-
Notifications
You must be signed in to change notification settings - Fork 200
Getting Started: Add rkdeveloptool guide #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe "Deploy the image" section of the User Guide was expanded and reorganized to present multiple deployment options. The documentation now uses a tabbed format to distinguish between "Flash to SD Card" and "Flash to Internal Memory" methods. The SD Card instructions retain the original USBImager recommendation and clarify that balenaEtcher is no longer recommended. The new "Flash to Internal Memory" tab provides detailed installation and usage instructions for the Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (3)
docs/User-Guide_Getting-Started.md (3)
178-179: Fix several grammar / spelling issues in the intro sentence
Minor language glitches creep into the very first sentence of this section:-There is multiple ways to deploy the image to your board. The easist and most common option is to write the Armbian Image to your SD-Card. Other options include using rkdeveloptool to flash the EMMC / UFS / SPI on Rockchip Boards directly over USB (via Maskrom Mode). +There are multiple ways to deploy the image to your board. The easiest and most common option is to write the Armbian image to your SD card. Other options include using `rkdeveloptool` to flash the eMMC/UFS/SPI on Rockchip boards directly over USB (MaskROM mode).This simultaneously fixes
• subject-verb agreement (There are)
• typo (easist→easiest)
• capitalisation of image / SD card and boards
• official spelling MaskROM, eMMC.
188-190: Remove superfluous blank line to satisfy markdownlint (MD012)
There are two consecutive blank lines after Line 188 which triggers MD012. Dropping one of them keeps the rendered output identical while silencing the linter.
230-236:$(nproc)is Linux-only – use a portable variant on macOS
nprocisn’t available on macOS, so the build command inside the macOS subsection will fail. Use the BSD-compatible CPU-count query or drop the job flag:-make -j $(nproc) +# macOS: parallel build +make -j $(sysctl -n hw.ncpu)Alternatively, a simple
makeis fine for beginners.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/User-Guide_Getting-Started.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/User-Guide_Getting-Started.md
[grammar] ~178-~178: Ensure spelling is correct
Context: ... to deploy the image to your board. The easist and most common option is to write the ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.17.2)
docs/User-Guide_Getting-Started.md
190-190: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
|
@igorpecovnik the action is missing permissions to add the preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
docs/User-Guide_Getting-Started.md (1)
197-200: Replace non-existentlibusb-1.0package
libusb-1.0is not an installable Debian package; the correct runtime library islibusb-1.0-0. The previous review already flagged this but it is still present.-sudo apt-get install -y libudev-dev libusb-1.0-0-dev dh-autoreconf pkg-config libusb-1.0 build-essential git wget +sudo apt-get install -y libudev-dev libusb-1.0-0-dev libusb-1.0-0 dh-autoreconf pkg-config build-essential git wget
🧹 Nitpick comments (3)
docs/User-Guide_Getting-Started.md (3)
178-179: Fix typo and subject–verb agreement in intro sentenceMinor wording issues:
• “There is” → “There are”
• “easist” → “easiest”
• “Image”/“SD-Card” mid-sentence should not be capitalised.-There is multiple ways to deploy the image to your board. The easist and most common option is to write the Armbian Image to your SD-Card. +There are multiple ways to deploy the image to your board. The easiest and most common option is to write the Armbian image to your SD card.
190-190: Remove superfluous blank line (markdownlint MD012)Two consecutive blank lines break the flow and trigger MD012.
-
224-236:nprocis Linux-specific – use portable CPU count on macOS
nprocis not available on macOS, causing the build step to fail. A portable approach:-make -j $(nproc) +CPU_COUNT=$(getconf _NPROCESSORS_ONLN 2>/dev/null || sysctl -n hw.ncpu) +make -j ${CPU_COUNT:-1}Optionally prefix the final copy step with
sudoto avoid permission errors when/opt/homebrew/binis root-owned.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/User-Guide_Getting-Started.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/User-Guide_Getting-Started.md
[grammar] ~178-~178: Ensure spelling is correct
Context: ... to deploy the image to your board. The easist and most common option is to write the ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.17.2)
docs/User-Guide_Getting-Started.md
190-190: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/User-Guide_Getting-Started.md (1)
204-207: Incorrect package namelibusb-1.0breaks apt installation (still unresolved)
libusb-1.0is not a valid Debian package; the correct runtime package islibusb-1.0-0. This was flagged previously but the line remains unchanged, so the install command will still fail.-sudo apt-get install -y libudev-dev libusb-1.0-0-dev dh-autoreconf pkg-config libusb-1.0 +sudo apt-get install -y libudev-dev libusb-1.0-0-dev libusb-1.0-0 dh-autoreconf pkg-config
🧹 Nitpick comments (1)
docs/User-Guide_Getting-Started.md (1)
178-178: Remove trailing whitespace to satisfy markdownlint MD009Line 178 ends with an extra space, triggering the reported MD009 violation.
-There are multiple ways to deploy the image to your board. The easiest and most common option is to write the Armbian Image to your SD-Card.␠ +There are multiple ways to deploy the image to your board. The easiest and most common option is to write the Armbian Image to your SD-Card.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/User-Guide_Getting-Started.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/User-Guide_Getting-Started.md
178-178: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: docs-preview
- GitHub Check: docs-preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
docs/User-Guide_Getting-Started.md (1)
206-206:apt-getstill references non-existent packagelibusb-1.0
Issue already pointed out in an earlier review but not yet fixed. Debian provideslibusb-1.0-0(runtime) andlibusb-1.0-0-dev(headers); plainlibusb-1.0will fail with “Unable to locate package”.-sudo apt-get install -y libudev-dev libusb-1.0-0-dev dh-autoreconf pkg-config libusb-1.0 +sudo apt-get install -y libudev-dev libusb-1.0-0-dev libusb-1.0-0 dh-autoreconf pkg-config
🧹 Nitpick comments (2)
docs/User-Guide_Getting-Started.md (2)
178-178: Remove trailing whitespace to satisfy markdown-lint (MD009).
A single superfluous space at the end of Line 178 is tripping the linter.-There are multiple ways to deploy the image to your board. The easiest and most common option is to write the Armbian Image to your SD-Card.␠ +There are multiple ways to deploy the image to your board. The easiest and most common option is to write the Armbian Image to your SD-Card.
251-251: Minor spelling: manufacturer’s
Line 251 uses “manufactures website”; the possessive form should be “manufacturer’s website”.-1. Connect & Boot your Board into Maskrom mode. Usually there is a button to hold for 5 seconds during boot else check your manufactures website. +1. Connect & boot your board into Maskrom mode. Usually there is a button to hold for 5 seconds during boot (check your manufacturer’s website).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/User-Guide_Getting-Started.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/User-Guide_Getting-Started.md
178-178: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
🪛 LanguageTool
docs/User-Guide_Getting-Started.md
[grammar] ~251-~251: Ensure spelling is correct
Context: ... ``` 1. Connect & Boot your Board into Maskrom mode. Usually there is a button to hold...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
This PR adds
rkdeveloptoolguides (linux / macos) as content tabs next to the classic installation via SD card.