Skip to content

Add "fall through" comments to stop GCC 7 complaining #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Add "fall through" comments to stop GCC 7 complaining #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hls/ngx_rtmp_hls_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,6 +1951,7 @@ ngx_rtmp_hls_video(ngx_rtmp_session_t *s, ngx_rtmp_header_t *h,
ngx_log_error(NGX_LOG_ERR, s->connection->log, 0,
"hls: error appending AUD NAL");
}
/* fall through */
case 9:
aud_sent = 1;
break;
Expand Down
2 changes: 1 addition & 1 deletion ngx_rtmp_access_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,8 @@ ngx_rtmp_access_rule(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
break;
}

/* "all" passes through */
#endif
/* fall through */

default: /* AF_INET */

Expand Down
3 changes: 3 additions & 0 deletions ngx_rtmp_amf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ ngx_rtmp_amf_read(ngx_rtmp_amf_ctx_t *ctx, ngx_rtmp_amf_elt_t *elts,
if (elts->type & NGX_RTMP_AMF_OPTIONAL) {
return NGX_OK;
}
/* fall through */
case NGX_ERROR:
return NGX_ERROR;
}
Expand Down Expand Up @@ -398,6 +399,7 @@ ngx_rtmp_amf_read(ngx_rtmp_amf_ctx_t *ctx, ngx_rtmp_amf_elt_t *elts,
if (ngx_rtmp_amf_get(ctx, &max_index, 4) != NGX_OK) {
return NGX_ERROR;
}
/* fall through */

case NGX_RTMP_AMF_OBJECT:
if (ngx_rtmp_amf_read_object(ctx, data,
Expand Down Expand Up @@ -592,6 +594,7 @@ ngx_rtmp_amf_write(ngx_rtmp_amf_ctx_t *ctx,
if (ngx_rtmp_amf_put(ctx, &max_index, 4) != NGX_OK) {
return NGX_ERROR;
}
/* fall through */

case NGX_RTMP_AMF_OBJECT:
type8 = NGX_RTMP_AMF_END;
Expand Down
1 change: 1 addition & 0 deletions ngx_rtmp_eval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ ngx_rtmp_eval(void *ctx, ngx_str_t *in, ngx_rtmp_eval_t **e, ngx_str_t *out,

name.len = p - name.data;
ngx_rtmp_eval_append_var(ctx, &b, e, &name, log);
/* fall through */

case NORMAL:
switch (c) {
Expand Down
2 changes: 2 additions & 0 deletions ngx_rtmp_init.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ ngx_rtmp_init_connection(ngx_connection_t *c)

case AF_UNIX:
unix_socket = 1;
/* fall through */

default: /* AF_INET */
sin = (struct sockaddr_in *) sa;
Expand Down Expand Up @@ -110,6 +111,7 @@ ngx_rtmp_init_connection(ngx_connection_t *c)

case AF_UNIX:
unix_socket = 1;
/* fall through */

default: /* AF_INET */
addr = port->addrs;
Expand Down
2 changes: 2 additions & 0 deletions ngx_rtmp_notify_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,7 @@ ngx_rtmp_notify_parse_http_header(ngx_rtmp_session_t *s,

n = 0;
state = parse_name;
/* fall through */

case parse_name:
switch (c) {
Expand Down Expand Up @@ -919,6 +920,7 @@ ngx_rtmp_notify_parse_http_header(ngx_rtmp_session_t *s,
break;
}
state = parse_value;
/* fall through */

case parse_value:
if (c == '\n') {
Expand Down