Skip to content

Conversation

@OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Sep 28, 2024

Description

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2389.org.readthedocs.build/en/2389/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (7e51ec9) to head (216bf56).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2389   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         124      124           
  Lines       12882    12882           
=======================================
  Hits        11183    11183           
  Misses       1699     1699           
Flag Coverage Δ
86.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except I am not able to see what are the actual changes on the notebook.

@OriolAbril
Copy link
Member Author

No changes, only checked it ran with the newest versions of everything

@OriolAbril OriolAbril merged commit 9411317 into arviz-devs:main Sep 28, 2024
@OriolAbril OriolAbril deleted the prepare_release branch September 28, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants