-
-
Notifications
You must be signed in to change notification settings - Fork 10
refactor: update for compatibility with asdf v0.16 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aabouzaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@egriff89 LGTM, but could you please add versions matrix in the readme file to show which version of asdf plugin manager works with witch version of asdf.
|
@aabouzaid I've updated the readme. |
|
@aabouzaid gentle ping. when merge this pr? |
|
@aabouzaid You really should merge this. Everything's been done for you. The community is waiting. |
|
Thanks for the heads up, I will merge and release today 👍 |
aabouzaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, asdf plugin list is supported in old Asdf versions as well, but we added a compatibility matrix for completeness.
asdf was recently updated to 0.16 and includes a multitude of breaking changes, some of which include the removal of hyphenated commands. This fixes the
export_plugins()function to useasdf plugin listinstead ofasdf plugin-listto restore the intended functionality instead of the broken help text shown below.Before:
After:
$ asdf-plugin-manager.sh export direnv https://github.com/asdf-community/asdf-direnv.git 951acd38bf9aa2258a00a5d87cc9d971fd344a60 pipx https://github.com/yozachar/asdf-pipx.git 31db61862805766b456e8920c635c19872ac87a7