Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
f611a18
Add rubocop with a todo list
samsonjs Jun 28, 2025
2967344
Run rubocop as part of the CI workflow
samsonjs Jun 28, 2025
69f5e39
Autofix for RuboCop: Layout/ElseAlignment
pieterocp Jun 30, 2025
672a086
Regen autogen, removing all claude-scratchpad/*
pieterocp Jun 30, 2025
b4daa9b
Autofix RuboCop Layout/EmptyLine
pieterocp Jun 30, 2025
86f2485
AutoFix RuboCop Style/ZeroLengthPredicate
pieterocp Jun 30, 2025
223c84c
AutoFix RuboCop Layout/EmptyLinesAroundAccessModifier
pieterocp Jun 30, 2025
fc2add8
AutoFix RuboCop Layout/EmptyLinesAroundMethodBody
pieterocp Jun 30, 2025
aa596b8
AutoFix RuboCop Layout/EmptyLinesAroundBlockBody
pieterocp Jun 30, 2025
cf62a24
AutoFix RuboCop Layout/EmptyLinesAroundClassBody
pieterocp Jun 30, 2025
4cdf5f3
AutoFix RuboCop Layout/EndAlignment
pieterocp Jun 30, 2025
b683365
AutoFix RuboCop Layout/ExtraSpacing
pieterocp Jun 30, 2025
c9dfc20
AutoFix RuboCop Layout/FirstHashElementIndentation
pieterocp Jun 30, 2025
ea6126d
AutoFix RuboCop Layout/HashAlignment
pieterocp Jun 30, 2025
fc7ae90
AutoFix RuboCop Layout/IndentationWidth
pieterocp Jun 30, 2025
1b9aedf
Regenerate todo
pieterocp Jun 30, 2025
f5a1cdb
AutoFix RuboCop Layout/SpaceBeforeBlockBraces
pieterocp Jun 30, 2025
0ac8504
AutoFix RuboCop Layout/SpaceBeforeComma
pieterocp Jun 30, 2025
8b1f794
AutoFix RuboCop Layout/SpaceInsideBlockBraces
pieterocp Jun 30, 2025
433ace3
AutoFix RuboCop Layout/SpaceInsideHashLiteralBraces
pieterocp Jun 30, 2025
abcef47
AutoFix RuboCop Layout/TrailingEmptyLines
pieterocp Jun 30, 2025
d4bce13
Update ci.yml
samsonjs Jun 30, 2025
df63cfe
WIP: Remove claude-scratchpad cruft from rubocop todo
samsonjs Jun 30, 2025
d51a1db
Specify files explicity in rubocop rake task
samsonjs Jun 30, 2025
8dfd1e8
Pin rubocop version to 1.77.0
samsonjs Jun 30, 2025
78f7ba0
AutoFix RuboCop Style/TrailingCommaInHashLiteral
pieterocp Jul 8, 2025
9e33e1f
AutoFix RuboCop Style/StringLiteralsInInterpolation
pieterocp Jul 8, 2025
5eea5ab
AutoFix RuboCop Style/StringLiterals
pieterocp Jul 8, 2025
5e78a32
AutoFix RuboCop Style/RescueStandardError
pieterocp Jul 8, 2025
e6af1da
AutoFix RuboCop Style/RedundantPercentQ
pieterocp Jul 8, 2025
3a71be7
AutoFix RuboCop Style/RedundantConstantBase
pieterocp Jul 8, 2025
6f0ffc2
AutoFix RuboCop Style/QuotedSymbols
pieterocp Jul 8, 2025
481a6f6
AutoFix RuboCop Style/PercentLiteralDelimiters
pieterocp Jul 8, 2025
c1fa224
AutoFix RuboCop Style/ParallelAssignment
pieterocp Jul 8, 2025
a95640b
AutoFix RuboCop Style/MultilineIfModifier
pieterocp Jul 8, 2025
65aa464
AutoFix RuboCop Style/Lambda
pieterocp Jul 8, 2025
4ca251f
AutoFix RuboCop Style/IfUnlessModifier
pieterocp Jul 8, 2025
f6ae186
AutoFix RuboCop Style/HashSyntax
pieterocp Jul 8, 2025
b8d0831
AutoFix RuboCop Style/GuardClause
pieterocp Jul 8, 2025
086281a
AutoFix RuboCop Style/ExpandPathArguments
pieterocp Jul 8, 2025
f3552bc
AutoFix RuboCop Style/BlockDelimiters
pieterocp Jul 8, 2025
93b41a6
AutoFix RuboCop Style/BlockComments
pieterocp Jul 8, 2025
e5b6b00
AutoFix RuboCop Lint/UnusedMethodArgument
pieterocp Jul 8, 2025
f3ce256
AutoFix RuboCop Lint/SymbolConversion
pieterocp Jul 8, 2025
c9865f3
Merge branch 'master' into add-rubocop
samsonjs Jul 10, 2025
ba45a7d
Merge branch 'add-rubocop' into add-all-todos
pieterocp Jul 10, 2025
b338298
Fix auto-gen formatting + RuboCop AutoFix Style/ModuleFunction
pieterocp Jul 10, 2025
68fbe40
Merge pull request #1 from pieterocp/add-all-todos
samsonjs Jul 14, 2025
e113998
Code style
samsonjs Jul 14, 2025
0b857fb
Merge branch 'master' into add-rubocop
samsonjs Jul 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AutoFix RuboCop Layout/TrailingEmptyLines
  • Loading branch information
pieterocp committed Jun 30, 2025
commit abcef4750507bf0e54d70fc915bc663a7005ad64
10 changes: 0 additions & 10 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,6 @@ Gemspec/RequiredRubyVersion:
Exclude:
- 'grape_logging.gemspec'

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: final_newline, final_blank_line
Layout/TrailingEmptyLines:
Exclude:
- 'lib/grape_logging/multi_io.rb'
- 'lib/grape_logging/reporters/active_support_reporter.rb'
- 'lib/grape_logging/timings.rb'

# Offense count: 1
# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
Lint/DuplicateBranch:
Expand Down
2 changes: 1 addition & 1 deletion lib/grape_logging/multi_io.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ def close
@targets.each(&:close)
end
end
end
end
2 changes: 1 addition & 1 deletion lib/grape_logging/reporters/active_support_reporter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ def perform(params)
ActiveSupport::Notifications.instrument @instrumentation_key, params
end
end
end
end
2 changes: 1 addition & 1 deletion lib/grape_logging/timings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ def append_db_runtime(event)
self.db_runtime += event.duration
end
end
end
end