Skip to content

Add support for Grape 2.4 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonjs merged 4 commits into from
Aug 7, 2025
Merged

Add support for Grape 2.4 #93

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a20d392
Fix RequestLogger middleware to handle Grape 2.4 breaking chnage
devsigner Jun 19, 2025
4ecaf2e
Make RequestLogger#initialize signature match Grape 2.4
samsonjs Aug 7, 2025
ea84dc8
Update changelog
samsonjs Aug 7, 2025
bc2281e
Require grape >= 2.4 in gemspec
samsonjs Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make RequestLogger#initialize signature match Grape 2.4
  • Loading branch information
@samsonjs
samsonjs committed Aug 7, 2025
commit 4ecaf2edaa2ed1a4f4b7bf5d6472a8798b1178f4
4 changes: 2 additions & 2 deletions lib/grape_logging/middleware/request_logger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class RequestLogger < Grape::Middleware::Base
# to use int in parameters
attr_accessor :response_status, :response_body

def initialize(app, options = {})
super(app, **options)
def initialize(app, **options)
super

@included_loggers = @options[:include] || []
@reporter =
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/grape_logging/middleware/request_logger_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
let(:env) { { 'action_dispatch.request_id' => 'request-abc123' } }
let(:subject) { request.send(request_method, path, env) }
let(:app) { proc { [status, {}, ['response body']] } }
let(:stack) { described_class.new app, options }
let(:stack) { described_class.new app, **options }
let(:request) { Rack::MockRequest.new(stack) }
let(:options) { { include: [], logger: logger } }
let(:logger) { double('logger') }
Expand Down