Skip to content

Fix LinkedIn provider with v2 endpoints to get name, email and profile pictures #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2019
Merged

Fix LinkedIn provider with v2 endpoints to get name, email and profile pictures #298

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f36c829
Fix LinkedIn authentication with v2 endpoints to get name, email and …
asiffermann May 21, 2019
be7becb
Update unit tests with new JSON payload
asiffermann May 21, 2019
097f050
Resolve PR comments
asiffermann May 22, 2019
1ca0dde
Add MultiLocaleStringResolver to let the integrator decide which loca…
asiffermann May 22, 2019
47f0d60
Rename private member
asiffermann May 22, 2019
e7ff75c
Merge branch 'dev' of git://github.com/aspnet-contrib/AspNet.Security…
asiffermann May 22, 2019
3bf8c11
Fix PR comments, add tests with RequestLocalization
asiffermann May 22, 2019
e9628e6
I can't describe this commit without insulting myself :face_with_roll…
asiffermann May 22, 2019
2faddb4
Restore constants as obsolete
asiffermann May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename private member
  • Loading branch information
@asiffermann
asiffermann committed May 22, 2019
commit 47f0d60ce2a900511eccc3f48147dc5c9d364d57
6 changes: 3 additions & 3 deletions test/AspNet.Security.OAuth.Providers.Tests/LinkedIn/LinkedInTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace AspNet.Security.OAuth.LinkedIn
{
public class LinkedInTests : OAuthTests<LinkedInAuthenticationOptions>
{
private Action<LinkedInAuthenticationOptions> additionnalConfiguration = null;
private Action<LinkedInAuthenticationOptions> additionalConfiguration = null;

public LinkedInTests(ITestOutputHelper outputHelper)
{
Expand All @@ -32,7 +32,7 @@ protected internal override void RegisterAuthentication(AuthenticationBuilder bu
{
ConfigureDefaults(builder, options);
options.Fields.Add(LinkedInAuthenticationConstants.ProfileFields.PictureUrl);
additionnalConfiguration?.Invoke(options);
additionalConfiguration?.Invoke(options);
});
}

Expand Down Expand Up @@ -64,7 +64,7 @@ public async Task Can_Sign_In_Using_LinkedIn(string claimType, string claimValue
public async Task Can_Sign_In_Using_LinkedIn_Localized(string claimType, string claimValue)
{
// Arrange
additionnalConfiguration = options => options.MultiLocaleStringResolver = (values, preferredLocale) =>
additionalConfiguration = options => options.MultiLocaleStringResolver = (values, preferredLocale) =>
{
if (values.ContainsKey("fr_FR"))
{
Expand Down