Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
cffa395
Basic Apple provider
martincostello Jun 6, 2019
5c3d7cd
Implement Apple provider
martincostello Jun 8, 2019
f78fa43
Enable Sign In with Apple
martincostello Jun 8, 2019
7ba0afb
Update tests
martincostello Jun 8, 2019
7a24782
Enable token lifetime validation
martincostello Jun 8, 2019
c0fc31c
Add null annotations
martincostello Jun 9, 2019
cd8ed33
Improve exception handling
martincostello Jun 9, 2019
9bc3817
Extend integration tests
martincostello Jun 9, 2019
404730e
Move expiry period to options
martincostello Jun 9, 2019
8b11fe7
Add ClientSecretExpiresAfter validation
martincostello Jun 9, 2019
c7b2f74
Add tests for options validation
martincostello Jun 9, 2019
05a8102
Add unit tests for client secret
martincostello Jun 9, 2019
9948d08
Make KeyId required
martincostello Jun 9, 2019
5e72f38
Fix test
martincostello Jun 9, 2019
2d4794a
Fix Linux and macOS secret generation
martincostello Jun 9, 2019
13012dd
Add password option for pfx files
martincostello Jun 9, 2019
b9f329a
Fix flaky test
martincostello Jun 9, 2019
210fbf9
Add UsePrivateKey() method
martincostello Jun 9, 2019
94f1737
Bump System.IdentityModel.Tokens.Jwt
martincostello Jun 9, 2019
67dc9a3
Set response_mode to form_post
martincostello Sep 8, 2019
eae3d43
Use latest C# version
martincostello Sep 8, 2019
4a93eb6
Retrieve user details after sign-in
martincostello Sep 8, 2019
74f607a
Update branding
martincostello Sep 15, 2019
dbbf2db
Access events via options
martincostello Sep 15, 2019
785a01a
Resolve logging TODO
martincostello Sep 15, 2019
eb5ccfd
Comment out Apple option
martincostello Sep 20, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update branding
Use "Sign in with Apple" instead of "Sign In with Apple".
  • Loading branch information
martincostello committed Sep 15, 2019
commit 74f607a323bbac639bb982f6fc9a3f1ff47f7797
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace AspNet.Security.OAuth.Apple
{
/// <summary>
/// Default values used by the Apple (Sign In with Apple) authentication provider.
/// Default values used by the Apple (Sign in with Apple) authentication provider.
/// </summary>
public static class AppleAuthenticationDefaults
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
namespace Microsoft.Extensions.DependencyInjection
{
/// <summary>
/// Extension methods to add Sign In with Apple authentication capabilities to an HTTP application pipeline.
/// Extension methods to add Sign in with Apple authentication capabilities to an HTTP application pipeline.
/// </summary>
public static class AppleAuthenticationExtensions
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public AppleAuthenticationOptions()
public bool GenerateClientSecret { get; set; }

/// <summary>
/// Gets or sets the optional ID for your Sign In with Apple private key.
/// Gets or sets the optional ID for your Sign in with Apple private key.
/// </summary>
public string KeyId { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace Microsoft.Extensions.DependencyInjection
{
/// <summary>
/// Extension methods to configure Sign In with Apple authentication capabilities for an HTTP application pipeline.
/// Extension methods to configure Sign in with Apple authentication capabilities for an HTTP application pipeline.
/// </summary>
public static class AppleAuthenticationOptionsExtensions
{
Expand Down
6 changes: 3 additions & 3 deletions src/AspNet.Security.OAuth.Apple/AppleClientSecretGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@
namespace AspNet.Security.OAuth.Apple
{
/// <summary>
/// Represents the base class for a client secret generator for Sign In with Apple.
/// Represents the base class for a client secret generator for Sign in with Apple.
/// </summary>
public abstract class AppleClientSecretGenerator
{
/// <summary>
/// Generates a client secret for Sign In with Apple as an asynchronous operation.
/// Generates a client secret for Sign in with Apple as an asynchronous operation.
/// </summary>
/// <param name="context">The context.</param>
/// <returns>
/// A <see cref="Task{TResult}"/> representing the asynchronous operation
/// to generate a client secret for Sign In with Apple.
/// to generate a client secret for Sign in with Apple.
/// </returns>
public abstract Task<string> GenerateAsync(AppleGenerateClientSecretContext context);
}
Expand Down
6 changes: 3 additions & 3 deletions src/AspNet.Security.OAuth.Apple/AppleKeyStore.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace AspNet.Security.OAuth.Apple
{
/// <summary>
/// Represents the base class for a store containing the keys for use with Sign In with Apple.
/// Represents the base class for a store containing the keys for use with Sign in with Apple.
/// </summary>
public abstract class AppleKeyStore
{
Expand All @@ -19,7 +19,7 @@ public abstract class AppleKeyStore
/// <param name="context">The context.</param>
/// <returns>
/// A <see cref="Task{TResult}"/> representing the asynchronous operation
/// to get the raw bytes of the private key to use for Sign In with Apple.
/// to get the raw bytes of the private key to use for Sign in with Apple.
/// </returns>
public abstract Task<byte[]> LoadPrivateKeyAsync(AppleGenerateClientSecretContext context);

Expand All @@ -29,7 +29,7 @@ public abstract class AppleKeyStore
/// <param name="context">The context.</param>
/// <returns>
/// A <see cref="Task{TResult}"/> representing the asynchronous operation
/// to get the raw bytes of the public key to use for Sign In with Apple.
/// to get the raw bytes of the public key to use for Sign in with Apple.
/// </returns>
public abstract Task<byte[]> LoadPublicKeysAsync(AppleValidateIdTokenContext context);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public override async Task<byte[]> LoadPrivateKeyAsync([NotNull] AppleGenerateCl
if (context.Options.PrivateKeyBytes == null)
{
throw new ArgumentException(
$"The {nameof(AppleAuthenticationOptions.PrivateKeyBytes)} option must be set to be able to load the Sign In with Apple private key.",
$"The {nameof(AppleAuthenticationOptions.PrivateKeyBytes)} option must be set to be able to load the Sign in with Apple private key.",
nameof(AppleAuthenticationOptions.PrivateKeyBytes));
}

Expand Down