Update GitLab for ASP.NET Core 3.0

Update the GitLab provider to support ASP.NET Core 3.0.

.gitignore

@@ -16,7 +16,10 @@ project.lock.json
 
 # Build results
 
+.dotnetcli/
 artifacts/
+coverage/
+coverage.*
 [Dd]ebug/
 [Rr]elease/
 x64/

src/AspNet.Security.OAuth.GitLab/AspNet.Security.OAuth.GitLab.csproj

@@ -3,7 +3,7 @@
   <Import Project="..\..\build\packages.props" />
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFramework>netcoreapp3.0</TargetFramework>
   </PropertyGroup>
 
   <PropertyGroup>
@@ -13,8 +13,8 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <FrameworkReference Include="Microsoft.AspNetCore.App" />
     <PackageReference Include="JetBrains.Annotations" Version="$(JetBrainsVersion)" PrivateAssets="All" />
-    <PackageReference Include="Microsoft.AspNetCore.Authentication.OAuth" Version="$(AspNetCoreVersion)" />
   </ItemGroup>
 
 </Project>

src/AspNet.Security.OAuth.GitLab/GitLabAuthenticationExtensions.cs

@@ -50,7 +50,8 @@ public static AuthenticationBuilder AddGitLab(
         /// <param name="configuration">The delegate used to configure the GitLab options.</param>
         /// <returns>The <see cref="AuthenticationBuilder"/>.</returns>
         public static AuthenticationBuilder AddGitLab(
-            [NotNull] this AuthenticationBuilder builder, [NotNull] string scheme,
+            [NotNull] this AuthenticationBuilder builder,
+            [NotNull] string scheme,
             [NotNull] Action<GitLabAuthenticationOptions> configuration)
         {
             return builder.AddGitLab(scheme, GitLabAuthenticationDefaults.DisplayName, configuration);
@@ -67,7 +68,8 @@ public static AuthenticationBuilder AddGitLab(
         /// <returns>The <see cref="AuthenticationBuilder"/>.</returns>
         public static AuthenticationBuilder AddGitLab(
             [NotNull] this AuthenticationBuilder builder,
-            [NotNull] string scheme, [NotNull] string caption,
+            [NotNull] string scheme,
+            [NotNull] string caption,
             [NotNull] Action<GitLabAuthenticationOptions> configuration)
         {
             return builder.AddOAuth<GitLabAuthenticationOptions, GitLabAuthenticationHandler>(scheme, caption, configuration);

src/AspNet.Security.OAuth.GitLab/GitLabAuthenticationHandler.cs

@@ -8,13 +8,13 @@
 using System.Net.Http.Headers;
 using System.Security.Claims;
 using System.Text.Encodings.Web;
+using System.Text.Json;
 using System.Threading.Tasks;
 using JetBrains.Annotations;
 using Microsoft.AspNetCore.Authentication;
 using Microsoft.AspNetCore.Authentication.OAuth;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
-using Newtonsoft.Json.Linq;
 
 namespace AspNet.Security.OAuth.GitLab
 {
@@ -29,7 +29,10 @@ public GitLabAuthenticationHandler(
         {
         }
 
-        protected override async Task<AuthenticationTicket> CreateTicketAsync(ClaimsIdentity identity, AuthenticationProperties properties, OAuthTokenResponse tokens)
+        protected override async Task<AuthenticationTicket> CreateTicketAsync(
+            ClaimsIdentity identity,
+            AuthenticationProperties properties,
+            OAuthTokenResponse tokens)
         {
             // Get the GitLab user
             var request = new HttpRequestMessage(HttpMethod.Get, Options.UserInformationEndpoint);
@@ -48,11 +51,11 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(ClaimsIden
                 throw new HttpRequestException("An error occurred while retrieving the user profile.");
             }
 
-            var payload = JObject.Parse(await response.Content.ReadAsStringAsync());
+            using var payload = JsonDocument.Parse(await response.Content.ReadAsStringAsync());
 
             var principal = new ClaimsPrincipal(identity);
-            var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, payload);
-            context.RunClaimActions(payload);
+            var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, payload.RootElement);
+            context.RunClaimActions();
 
             await Options.Events.CreatingTicket(context);
             return new AuthenticationTicket(context.Principal, context.Properties, Scheme.Name);

src/AspNet.Security.OAuth.GitLab/GitLabAuthenticationOptions.cs

@@ -11,15 +11,18 @@
 
 namespace AspNet.Security.OAuth.GitLab
 {
+    /// <summary>
+    /// Defines a set of options used by <see cref="GitLabAuthenticationHandler"/>.
+    /// </summary>
     public class GitLabAuthenticationOptions : OAuthOptions
     {
         /// <summary>
-        /// Initializes a new <see cref="GitLabAuthenticationOptions"/>.
+        /// Initializes a new instance of the <see cref="GitLabAuthenticationOptions"/> class.
         /// </summary>
         public GitLabAuthenticationOptions()
         {
-            CallbackPath = GitLabAuthenticationDefaults.CallbackPath;
             AuthorizationEndpoint = GitLabAuthenticationDefaults.AuthorizationEndpoint;
+            CallbackPath = GitLabAuthenticationDefaults.CallbackPath;
             TokenEndpoint = GitLabAuthenticationDefaults.TokenEndpoint;
             UserInformationEndpoint = GitLabAuthenticationDefaults.UserInformationEndpoint;