Add tests for options validation

Add unit tests for options validation.
Improve exception type.
Fix incorrect if condition that meant not all values were validated correctly.

src/AspNet.Security.OAuth.Apple/AppleAuthenticationOptions.cs

@@ -122,7 +122,7 @@ public override void Validate()
                 throw new ArgumentException($"The '{nameof(CallbackPath)}' option must be provided.", nameof(CallbackPath));
             }
 
-            if (GenerateClientSecret && string.IsNullOrEmpty(TeamId))
+            if (GenerateClientSecret)
             {
                 if (string.IsNullOrEmpty(TeamId))
                 {
@@ -136,7 +136,10 @@ public override void Validate()
 
                 if (ClientSecretExpiresAfter <= TimeSpan.Zero)
                 {
-                    throw new ArgumentException($"The '{nameof(ClientSecretExpiresAfter)}' option must be a positive value if the '{nameof(GenerateClientSecret)}' option is set to true.", nameof(ClientSecretExpiresAfter));
+                    throw new ArgumentOutOfRangeException(
+                        nameof(ClientSecretExpiresAfter),
+                        ClientSecretExpiresAfter,
+                        $"The '{nameof(ClientSecretExpiresAfter)}' option must be a positive value if the '{nameof(GenerateClientSecret)}' option is set to true.");
                 }
             }
 

test/AspNet.Security.OAuth.Providers.Tests/Apple/AppleAuthenticationOptionsTests.cs

@@ -0,0 +1,135 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
+ * See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers
+ * for more information concerning the license and the contributors participating to this project.
+ */
+
+using System;
+using Xunit;
+
+namespace AspNet.Security.OAuth.Apple
+{
+    public static class AppleAuthenticationOptionsTests
+    {
+        [Fact]
+        public static void Validate_Throws_If_ClientSecret_Is_Null_With_No_Secret_Generation()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                ClientSecret = null,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentException>("ClientSecret", () => options.Validate());
+        }
+
+        [Fact]
+        public static void Validate_Throws_If_AuthorizationEndpoint_Is_Null()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                GenerateClientSecret = true,
+                AuthorizationEndpoint = null,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentException>("AuthorizationEndpoint", () => options.Validate());
+        }
+
+        [Fact]
+        public static void Validate_Throws_If_TokenEndpoint_Is_Null()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                GenerateClientSecret = true,
+                TokenEndpoint = null,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentException>("TokenEndpoint", () => options.Validate());
+        }
+
+        [Fact]
+        public static void Validate_Throws_If_CallbackPath_Is_Null()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                GenerateClientSecret = true,
+                CallbackPath = null,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentException>("CallbackPath", () => options.Validate());
+        }
+
+        [Fact]
+        public static void Validate_Throws_If_TeamId_Is_Null_With_Secret_Generation()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                GenerateClientSecret = true,
+                TeamId = null,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentException>("TeamId", () => options.Validate());
+        }
+
+        [Fact]
+        public static void Validate_Throws_If_TokenAudience_Is_Null_With_Secret_Generation()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                GenerateClientSecret = true,
+                TeamId = "my-team-id",
+                TokenAudience = null,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentException>("TokenAudience", () => options.Validate());
+        }
+
+        [Fact]
+        public static void Validate_Throws_If_ClientSecretExpiresAfter_Is_Zero_With_Secret_Generation()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                GenerateClientSecret = true,
+                TeamId = "my-team-id",
+                ClientSecretExpiresAfter = TimeSpan.Zero,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentOutOfRangeException>("ClientSecretExpiresAfter", () => options.Validate());
+        }
+
+        [Fact]
+        public static void Validate_Throws_If_PublicKeyEndpoint_Is_Null_With_Token_Validation()
+        {
+            // Arrange
+            var options = new AppleAuthenticationOptions()
+            {
+                ClientId = "my-client-id",
+                ClientSecret = "my-client-secret",
+                PublicKeyEndpoint = null,
+            };
+
+            // Act and Assert
+            Assert.Throws<ArgumentException>("PublicKeyEndpoint", () => options.Validate());
+        }
+    }
+}