Restore Newtonsoft.Json #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert breaking change made in aspnet-contrib#70, instead making the new System.Text.Json support an addition, rather than a replacement.
Member
Author
|
@kevinchalet No worries if you’re busy and can’t reply, but any thoughts on this PR? |
kevinchalet
approved these changes
Mar 26, 2020
Member
kevinchalet
left a comment
kevinchalet
left a comment
There was a problem hiding this comment.
Very elegant approach. Thank you very much!
Member
Author
|
Thanks! I’ll look at creating a 3.1 candidate with this in it later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert breaking change made in #70, instead making the new System.Text.Json support an addition, rather than a replacement.
In a future v4 (or v5) release we can change the type over as originally intended and remove the new alternate
UserProfileproperty.