Skip to content

2001.1.0 Release#63

Merged
icolwell-as merged 2 commits intoros2_masterfrom
2001.1.0_release
Dec 13, 2021
Merged

2001.1.0 Release#63
icolwell-as merged 2 commits intoros2_masterfrom
2001.1.0_release

Conversation

@icolwell-as
Copy link
Copy Markdown
Member

Resolves #27 by Releasing the first ROS2 version of this driver.

This 2001.1.0 version will coincide with an updated 1.1.0 release of the ROS1 driver.

@icolwell-as
Copy link
Copy Markdown
Member Author

Tested with GigE Mako G-319. Works as expected.
Hoping @Souphis has time on Monday to test on the USB camera to confirm it works.

@gbartyzel
Copy link
Copy Markdown

gbartyzel commented Dec 13, 2021

@icolwell-as So, I managed to run USB cameras with this version. However, there are some problems with the parameter server. Some float parameters cannot be set after reading them from cameras. For example, the gain range is (0.0, 8.0), the current cameras gain is 2.6, and then the driver gives an error that, the value is out of the range. The same happens with exposure_time, etc, the problem doesn't exist with auto mode enabled.
Also, I think there should be a service for stopping and starting cameras. To set the purpose of the GPIO you have to choose the line and then set the feature value. When doing this during runtime, the driver freezes.

@icolwell-as
Copy link
Copy Markdown
Member Author

Thanks for testing @Souphis! I can't seem to reproduce your gain/exposure parameters issues with my camera. I suggest creating a new issue and describing the steps you followed to reproduce the issues/errors.
Regarding the service for starting/stopping the camera, each time a parameter is updated, the camera stream is stopped and started again, see here. Is this not working quite right for you?

Anyway, since we are in a bit of a time crunch, and this version mostly works, I'm going to go ahead and release this version, then we can work on updates to resolve your issues for a future release.

Thanks again for testing and confirming it works!

@gbartyzel
Copy link
Copy Markdown

@icolwell-as ok, so release it. If you don't mind I can try to rewrite it to life cycle node (this will resolve the need for start/stop). And about this parameter error, I will try to reproduce this today or in the proceeding days.

@icolwell-as icolwell-as merged commit d92459c into ros2_master Dec 13, 2021
@icolwell-as icolwell-as deleted the 2001.1.0_release branch December 13, 2021 16:12
@icolwell-as
Copy link
Copy Markdown
Member Author

@Souphis certainly! happy to take any PR you think is an improvement into consideration! lifecycle is probably the best way to handle the parameter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants