Skip to content

Expose generic error codes for CredentialsManagerError #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Expose generic error codes for CredentialsManagerError #1076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ebe3c0
Use BaseError instead of Error
kailash-b Feb 11, 2025
cdfe8a2
Bundle errors from android and iOS into platform agnostic error codes
kailash-b Feb 13, 2025
1f1fe55
Added unit tests and addressed review comments
kailash-b Feb 17, 2025
4e14799
renamed generic_error_code to 'type'
kailash-b Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use BaseError instead of Error
  • Loading branch information
@kailash-b
kailash-b committed Feb 18, 2025
commit 4ebe3c08f2512154465122ca020edf29b587fa4e
3 changes: 2 additions & 1 deletion src/hooks/auth0-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
RevokeOptions,
ResetPasswordOptions,
} from '../types';
import BaseError from 'src/utils/baseError';

export interface Auth0ContextInterface<TUser extends User = User>
extends AuthState<TUser> {
Expand Down Expand Up @@ -143,7 +144,7 @@ export interface AuthState<TUser extends User = User> {
/**
* An object representing the last exception
*/
error: Error | null;
error: BaseError | null;
/**
* The user profile as decoded from the ID token after authentication
*/
Expand Down
3 changes: 2 additions & 1 deletion src/hooks/reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import BaseError from 'src/utils/baseError';
import { User } from '../types';
import { deepEqual } from '../utils/deepEqual';
import { AuthState } from './auth0-context';

type Action =
| { type: 'LOGIN_COMPLETE'; user: User }
| { type: 'LOGOUT_COMPLETE' }
| { type: 'ERROR'; error: Error }
| { type: 'ERROR'; error: BaseError }
Copy link
Contributor

@poovamraj poovamraj Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What value do we provide to generic_error_code if for authentication errors.

Copy link
Contributor Author

@kailash-b kailash-b Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is left empty.
The field is currently populated only in case of a CredentialManagerException.
We can re-use this field when we collate the Authentication Errors as well (tracked as part of SDK-5700).

| { type: 'INITIALIZED'; user: User | null }
| { type: 'SET_USER'; user: User };

Expand Down