-
Notifications
You must be signed in to change notification settings - Fork 34
Add exemplar support #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exemplar support #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! That was a lot easier to implement than I thought it would :) I just added a few non-blocking nitpicks
|
Already discussed out of bands, but I do feel like we should support the So in that sense I do agree with @gagbo that that maybe it would make sense to use a different name for the field as otherwise it would be confusing with the actual tracing. |
This adds a
Layerfortracingthat exposes theSpanfields toautometrics. It can then look for a field calledtrace_idand then automatically attach that as an exemplar for the metrics it generates.TODO:
--enable-feature=exemplar-storageflag and actually scrape the metrics and exemplarsResolves #26