Skip to content

fix compile error on generic impl traits within types #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 3, 2023
Merged

fix compile error on generic impl traits within types #122

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e843986
fix compile error on generic `impl` traits within types
mellowagain Jun 29, 2023
1a5eaf2
debranch a bit
mellowagain Jun 29, 2023
b2502a2
revert cargofmt on unintended change
mellowagain Jun 29, 2023
f5f8e08
add more tests for more edge cases
mellowagain Jul 3, 2023
25138ea
fix compile error on alias'd `Result`s with no explicit `Err` type arg
mellowagain Jul 3, 2023
6d5de7c
allow inferring both arguments in test d
mellowagain Jul 3, 2023
ab9d382
actually include `::` between path segments
mellowagain Jul 3, 2023
7136a40
Merge branch 'main' into issue-121
mellowagain Jul 3, 2023
e13f5e8
update changelog
mellowagain Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix compile error on alias'd Results with no explicit Err type arg
  • Loading branch information
@mellowagain
mellowagain committed Jul 3, 2023
commit 25138eaa8850fe9187a1dadf7da9d9ae51795a35
9 changes: 6 additions & 3 deletions autometrics-macros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ fn instrument_function(args: &AutometricsArgs, item: ItemFn) -> Result<TokenStre
});
}

quote! { <#(#ts,)*> }
quote! { <#(#ts),*> }
}
_ => quote! {},
};
Expand Down Expand Up @@ -244,7 +244,7 @@ fn instrument_function(args: &AutometricsArgs, item: ItemFn) -> Result<TokenStre
quote! {}
};

Ok(quote! {
let a = quote! {
#(#attrs)*

// Append the metrics documentation to the end of the function's documentation
Expand Down Expand Up @@ -280,7 +280,10 @@ fn instrument_function(args: &AutometricsArgs, item: ItemFn) -> Result<TokenStre

result
}
})
};

//panic!("{}", a);
Ok(a)
}

/// Add autometrics instrumentation to an entire impl block
Expand Down